refactor: use Storage interface instead of direct struct #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can get quiet hard to test structs in Go and functions using them. With this, the rest of the code can be mocked easier with a TestBackend which is just sits in memory and no encryption. The encryption should be tested on storage layer, but the rest of the application should care only about the exposed functions. related to #8 and #37 References: - #8 - #37 Signed-off-by: Victoria Nadasdi <victoria@efertone.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can get quiet hard to test structs in Go and functions using them. With this, the rest of the code can be mocked easier with a TestBackend which is just sits in memory and no encryption. The encryption should be tested on storage layer, but the rest of the application should care only about the exposed functions.
related to #8 and #37
References: