Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BigLoop benchmark. #12

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Add BigLoop benchmark. #12

merged 1 commit into from
Oct 9, 2024

Conversation

vext01
Copy link
Contributor

@vext01 vext01 commented Oct 7, 2024

This will serve as our first optimisation target.

We are still 3x slower than Lua, even with -O2.

(I copied the licensing from the main yk repo, which appears to be dual apache/mit)

(It's almost not worth licensing at this stage)

vext01
vext01 commented Oct 7, 2024
View reviewed changes
rebench.conf Outdated
command: " ../../awfy/Lua/harness.lua %(benchmark)s %(iterations)s "
max_invocation_time: 600 # seconds per vm invocation
min_iteration_time: 200 # miliseconds per iteration
invocations: 1 # the number of process executions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gah, this is supposed to be higher -- bear with

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 1b02e8e

@vext01
Copy link
Contributor Author

vext01 commented Oct 7, 2024

(will need squash)

@ptersilie
Copy link
Contributor

Please squash.

@vext01
Copy link
Contributor Author

vext01 commented Oct 7, 2024

splat.

@ptersilie ptersilie added this pull request to the merge queue Oct 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 7, 2024
@vext01
Copy link
Contributor Author

vext01 commented Oct 7, 2024

fatal: destination path 'yk' already exists and is not an empty directory

hah! that's quite amusing. I called the new suite yk and we then can't clone theyk repo.

@vext01
Copy link
Contributor Author

vext01 commented Oct 7, 2024

c90dfb9 moves the suites into a sub-folder so that there's no name clash.

Up to you whether we squash that in or not.

@ptersilie
Copy link
Contributor

ptersilie commented Oct 8, 2024 •
edited
Loading

Please squash.

@vext01
Copy link
Contributor Author

vext01 commented Oct 8, 2024

squashed.

@vext01
Copy link
Contributor Author

vext01 commented Oct 8, 2024

This can go in now.

@ptersilie ptersilie added this pull request to the merge queue Oct 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2024
@vext01
Copy link
Contributor Author

vext01 commented Oct 8, 2024 

14:06:51 + cargo run results html
14:06:51     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.03s
14:06:51      Running `target/debug/reporter results html`
14:06:51 thread 'main' panicked at src/main.rs:75:25:

something to do with the reporter, investigating...

@vext01
Copy link
Contributor Author

vext01 commented Oct 8, 2024

OK to squash?

@ptersilie
Copy link
Contributor

Please squash.

@vext01
Add BigLoop benchmark.
39d23e2 
This will serve as our first optimisation target.

(also move suites into a sub-directory)
@vext01
Copy link
Contributor Author

vext01 commented Oct 9, 2024

squashed

@ptersilie ptersilie added this pull request to the merge queue Oct 9, 2024
Merged via the queue into ykjit:main with commit f58ba94 Oct 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ptersilie ptersilie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vext01 @ptersilie