Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Only rescan when bitbake settings are changed #24

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

deribaucourt
Copy link
Member

The extension started scanning twice at startup. It turns out this was because the extension was sending a rescan request when the python embedded settings where updated. This was fixed by only sending a rescan request when the bitbake settings are changed.

The extension started scanning twice at startup. It turns out this was
because the extension was sending a rescan request when the python
embedded settings where updated. This was fixed by only sending a
rescan request when the bitbake settings are changed.
@WilsonZiweiWang
Copy link
Contributor

so somehow the python extension setting change triggered the config change event in our language server? That's an odd behaviour. but anyway, the extra scan is gone. Good job!

@deribaucourt deribaucourt merged commit 023e458 into yoctoproject:staging Dec 6, 2023
1 check passed
@deribaucourt deribaucourt deleted the fix-scan branch December 6, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants