No parsing recipes on watch event #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deribaucourt
previously approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Alright with me. Maybe wait for @idillon-sfl to be notified
ioioioio
approved these changes
Jan 2, 2024
WilsonZiweiWang
force-pushed
the
Remove-watch-event
branch
from
efc6a3a
to
d2d5668
Compare
WilsonZiweiWang
force-pushed
the
Remove-watch-event
branch
from
d2d5668
to
e9a1670
Compare
|
I keep the watch options in the client in case we need them later. |
idillon-sfl
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the parsing of recipes will happen in
onDidSave.@idillon-sfl According to #30
If we want to remove any watch events, the embedded part needs to be implemented somewhere else.