[WIP] Refactoring/dry #224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mondaini I merged your other PR and it seems that your fork is not updated. Please update it and resolve the merge conflicts. |
|
No problem @manparvesh :-) There are other DRY violations I found that I intend to fix. I believe that the project's Coverage will improve after these changes. |
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
==========================================
- Coverage 76.37% 71.81% -4.56%
==========================================
Files 59 55 -4
Lines 3357 3151 -206
==========================================
- Hits 2564 2263 -301
- Misses 793 888 +95
Continue to review full report at Codecov.
|
42B
reviewed
Nov 1, 2018
| click.echo("Number | Date ") | ||
| click.echo("--------------------") | ||
| for i, some_file in enumerate(range(0, len(list_of_files))): | ||
| click.echo(str(i) + " |" + list_of_files[some_file][0:10]) |
There was a problem hiding this comment.
for i, some_file in enumerate(list_of_files):
click.echo(str(i) + " |" + some_file[:10])| click.echo("Number | Date ") | ||
| click.echo("--------------------") | ||
| for i, some_file in enumerate(range(0, len(list_of_files))): | ||
| click.echo(str(i) + " |" + list_of_files[some_file][0:10]) |
|
v1 is now deprecated, closing old PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves: Fixing some DRY violations
Fixes: #223