Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] added suggest food and user recipe suggestion for specific interest #252

Closed
wants to merge 1 commit into from

Conversation

pyjka
Copy link

@pyjka pyjka commented Jan 26, 2019

Short description of what this resolves:

As it was absent in TODO, I have created a Food recipe module + Food suggestion module.
Also, to keep it DRY , I made functions out of decorated function.

Changes proposed in this pull request:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the README with example

Fixes: #

@codecov-io
Copy link

codecov-io commented Jan 26, 2019

Codecov Report

Merging #252 into master will decrease coverage by 0.64%.
The diff coverage is 23.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
- Coverage    76.4%   75.75%   -0.65%     
==========================================
  Files          61       61              
  Lines        3568     3609      +41     
==========================================
+ Hits         2726     2734       +8     
- Misses        842      875      +33
Impacted Files Coverage Δ
modules/food.py 56.96% <23.25%> (-40.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b963b93...19e55ac. Read the comment docs.

@pyjka
Copy link
Author

pyjka commented Jan 26, 2019

I'll add test asap, havent read throughout click documentation, just the things I've needed.

@manparvesh manparvesh changed the title added suggest food and user recipe suggestion for specific interest [WIP] added suggest food and user recipe suggestion for specific interest Jan 27, 2019
@manparvesh
Copy link
Member

@pyjka please remove the [WIP] from the status and comment here whenever you are done so that I can review

@manparvesh
Copy link
Member

v1 is now deprecated, closing old PRs

@manparvesh manparvesh closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants