Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Enhance unused jobs discovery #336

Merged

Conversation

nati-elmaliach
Copy link
Contributor

@nati-elmaliach nati-elmaliach commented Jul 28, 2024

What this PR does / why we need it?

Enhance unused Jobs discovery.

PR Checklist

  • This PR adds K8s exceptions (false positives)
  • This PR adds new code
  • This PR includes tests for new/existing code
  • This PR adds docs

GitHub Issue

Closes #315

Notes for your reviewers

image

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.45%. Comparing base (01ce4a6) to head (8725dc7).
Report is 5 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   42.39%   42.45%   +0.05%     
==========================================
  Files          61       61              
  Lines        3236     3239       +3     
==========================================
+ Hits         1372     1375       +3     
  Misses       1644     1644              
  Partials      220      220              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@doronkg doronkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, the expected jobs validation under jobs_test.go is nicely done.
Left 2 small comments regarding docs/spelling.

Can you attach an output example for the feature?

pkg/kor/jobs_test.go Outdated Show resolved Hide resolved
pkg/kor/jobs.go Show resolved Hide resolved
@yonahd yonahd merged commit c70a3ac into yonahd:main Aug 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Enhance unused Jobs discovery
4 participants