-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Enhance unused jobs discovery #336
Feat: Enhance unused jobs discovery #336
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
==========================================
+ Coverage 42.39% 42.45% +0.05%
==========================================
Files 61 61
Lines 3236 3239 +3
==========================================
+ Hits 1372 1375 +3
Misses 1644 1644
Partials 220 220 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, the expected jobs validation under jobs_test.go
is nicely done.
Left 2 small comments regarding docs/spelling.
Can you attach an output example for the feature?
What this PR does / why we need it?
Enhance unused Jobs discovery.
PR Checklist
GitHub Issue
Closes #315
Notes for your reviewers