Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): Update release badges & ClusterRole aggregation #340

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

doronkg
Copy link
Contributor

@doronkg doronkg commented Jul 31, 2024

What this PR does / why we need it?

This PR adds 2 small fixes to README.md:

  1. Adds discovery reference for ClusterRole aggregation (added in fix: ClusterRole Aggregation #221).
  2. Separates release badges for kor & Helm.

Current:
image
Updated:
image

PR Checklist

  • This PR adds K8s exceptions (false positives)
  • This PR adds new code
  • This PR includes tests for new/existing code
  • This PR adds docs

Notes for your reviewers

I used https://shields.io/badges/git-hub-release to test the badges.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.39%. Comparing base (01ce4a6) to head (1a35afc).
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   42.39%   42.39%           
=======================================
  Files          61       61           
  Lines        3236     3236           
=======================================
  Hits         1372     1372           
  Misses       1644     1644           
  Partials      220      220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonahd yonahd merged commit 2338459 into yonahd:main Jul 31, 2024
1 check passed
@doronkg doronkg deleted the docs/readme branch August 5, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants