Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Reference exceptions in CONTRIBUTING.md #367

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Conversation

doronkg
Copy link
Contributor

@doronkg doronkg commented Oct 20, 2024

What this PR does / why we need it?

Reference pkg/kor/exceptions in directory structure under CONTRIBUTING.md.

PR Checklist

  • This PR adds K8s exceptions (false positives)
  • This PR adds new code
  • This PR includes tests for new/existing code
  • This PR adds docs

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.86%. Comparing base (673c21e) to head (a9b0292).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
- Coverage   44.48%   42.86%   -1.62%     
==========================================
  Files          63       63              
  Lines        3356     3961     +605     
==========================================
+ Hits         1493     1698     +205     
- Misses       1622     2022     +400     
  Partials      241      241              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonahd yonahd merged commit a80bdfa into yonahd:main Oct 20, 2024
1 check passed
@doronkg doronkg deleted the patch-1 branch October 20, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants