Implement new functions in JsonArray #110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Some public functions of
JsonArray
exist in JS and iOS SDK, but not in the Android SDK. These functions include:insertAfter()
,insertBefore()
moveAfter()
,moveBefore()
,moveFirst()
,moveLast()
splice()
Regarding the insert functions (1), it is kind of tricky to implement them as separate functions in the Android SDK, so I implemented the same feature of
insertAfter()
by modifying theput
methods. I guessinsertAfter()
can cover the expected behaviors ofinsertBefore()
, so I did not implement it.The move functions (2) are implemented the same way as in other SDKs.
As for
splice()
, it is a JavaScript method and seems unnecessary for Kotlin. (I am considering addingreplace()
instead ofsplice()
, but maybe it would be better to keep it until it is actually necessary).+) All the
JsonElement
s haveid
, so I definedid
property inJsonElement
instead of implementing it in each of its child class.Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist