Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Remote/LocalChange to have a single ChangeInfo #112

Merged
merged 5 commits into from
Jun 23, 2023
Merged

Conversation

7hong13
Copy link
Contributor

@7hong13 7hong13 commented Jun 23, 2023

What this PR does / why we need it?

Remote/LocalChange previously had a List<ChangeInfo>, but it has been changed to have a single ChangeInfo.

Any background context you want to provide?

What are the relevant tickets?

yorkie-team/yorkie-js-sdk#538

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@7hong13 7hong13 self-assigned this Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #112 (2409f3a) into main (315ce1d) will increase coverage by 0.16%.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##               main     #112      +/-   ##
============================================
+ Coverage     80.13%   80.30%   +0.16%     
  Complexity      587      587              
============================================
  Files            53       53              
  Lines          2663     2660       -3     
  Branches        364      363       -1     
============================================
+ Hits           2134     2136       +2     
+ Misses          337      332       -5     
  Partials        192      192              
Impacted Files Coverage Δ
yorkie/src/main/kotlin/dev/yorkie/core/Client.kt 77.62% <ø> (ø)
...ie/src/main/kotlin/dev/yorkie/document/Document.kt 69.92% <87.50%> (+3.01%) ⬆️

@7hong13 7hong13 merged commit 0f8f9ec into main Jun 23, 2023
@7hong13 7hong13 deleted the change_info branch June 23, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants