Add metrics for WatchDocuments and enhance pushpull metrics #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the event count is increased when client occurred watch document events. - the payload bytes is increased when client occurred watch document events especially broadcast event. - all metrics is labeled by project info, hostname and doc event type.
|
Caution Review failedThe pull request is closed. WalkthroughThe pull request introduces enhancements to metrics tracking and functionality within the server's document handling and event processing systems. Key changes include the addition of a new method for calculating payload lengths, improved metrics logging with contextual parameters, and the introduction of new labels for Prometheus metrics. These modifications provide better tracking and analysis of document events and operations, facilitating improved monitoring capabilities. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Server
participant Metrics
Client->>Server: Request document watch
Server->>Metrics: AddWatchDocumentConnections(hostname, project)
Metrics-->>Server: Acknowledge tracking
Server-->>Client: Send watch response
Client->>Server: Request document unwatch
Server->>Metrics: RemoveWatchDocumentConnections(hostname, project)
Metrics-->>Server: Acknowledge removal
Server-->>Client: Send unwatch response
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (4)
server/profiling/prometheus/metrics.go (1)
364-379: LGTM, but address the long line issue.The code changes are approved.
The
AddWatchDocumentEventPayloadBytesfunction enhances the ability to categorize and filter metrics based on thehostname,project, anddocEventTypelabels, providing more detailed tracking of event payload bytes in document watch stream connections.However, please address the long line issue flagged by the static analysis tool at line 365 to improve code readability. Consider breaking the line into multiple lines or extracting the labels into a separate variable.
Tools
golangci-lint
365-365: line is 138 characters
(lll)
server/rpc/yorkie_server.go (3)
Line range hint
433-483: Metrics changes LGTM! Refactor the long line.The changes related to metrics tracking, such as renaming the methods to plural forms (
AddWatchDocumentConnections,RemoveWatchDocumentConnections) and adding new metrics (AddWatchDocumentEventPayloadBytes), are improvements that provide better insights into the system's performance.However, line 483 exceeds the line length limit. Please refactor it to improve readability.
-s.backend.Metrics.AddWatchDocumentEventPayloadBytes(s.backend.Config.Hostname, project, event.Type, event.Body.PayloadLen()) +s.backend.Metrics.AddWatchDocumentEventPayloadBytes( + s.backend.Config.Hostname, + project, + event.Type, + event.Body.PayloadLen(), +)
586-586: Refactor the long line.Line 586 exceeds the line length limit. Please refactor it to improve readability.
-s.backend.Metrics.AddWatchDocumentEventPayloadBytes(s.backend.Config.Hostname, projects.From(ctx), types.DocumentWatchedEvent, 0) +s.backend.Metrics.AddWatchDocumentEventPayloadBytes( + s.backend.Config.Hostname, + projects.From(ctx), + types.DocumentWatchedEvent, + 0, +)Tools
golangci-lint
586-586: line is 130 characters
(lll)
Line range hint
659-673: Metrics changes LGTM! Refactor the long line.The changes related to metrics tracking, such as adding new metrics (
AddWatchDocumentEventPayloadBytes), are improvements that provide better insights into the system's performance.However, line 673 exceeds the line length limit. Please refactor it to improve readability.
-s.backend.Metrics.AddWatchDocumentEventPayloadBytes(s.backend.Config.Hostname, project, docEventType, len(req.Msg.Payload)) +s.backend.Metrics.AddWatchDocumentEventPayloadBytes( + s.backend.Config.Hostname, + project, + docEventType, + len(req.Msg.Payload), +)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- api/types/event.go (1 hunks)
- server/packs/packs.go (1 hunks)
- server/profiling/prometheus/metrics.go (7 hunks)
- server/rpc/yorkie_server.go (7 hunks)
Additional context used
golangci-lint
server/profiling/prometheus/metrics.go
365-365: line is 138 characters
(lll)
server/rpc/yorkie_server.go
483-483: line is 127 characters
(lll)
586-586: line is 130 characters
(lll)
611-611: line is 132 characters
(lll)
673-673: line is 124 characters
(lll)
Additional comments not posted (12)
api/types/event.go (1)
31-32: LGTM!The code changes are approved.
server/packs/packs.go (1)
84-85: LGTM!The code changes are approved.
The addition of
hostnameandprojectparameters to the metrics methods enhances the ability to categorize and filter metrics based on these labels, providing more detailed tracking of metrics associated with specific projects and hostnames.Also applies to: 93-94, 106-114, 116-125, 126-135, 137-146, 154-162
server/profiling/prometheus/metrics.go (9)
59-65: LGTM!The code changes are approved.
The updates to the
Metricsstruct, including the replacement of several existingprometheus.Countertypes withprometheus.CounterVecand the addition of new fields for tracking document watch events, enhance the metrics' capability to provide insights into the system's performance and behavior by allowing for more detailed categorization and tracking of events and operations.Also applies to: 68-70, 106-125, 126-135, 137-146, 154-162, 193-214
232-237: LGTM!The code changes are approved.
The addition of
hostnameandprojectparameters to theAddPushPullReceivedChangesfunction enhances the ability to categorize and filter metrics based on these labels, providing more detailed tracking of metrics associated with specific projects and hostnames.
242-247: LGTM!The code changes are approved.
The addition of
hostnameandprojectparameters to theAddPushPullSentChangesfunction enhances the ability to categorize and filter metrics based on these labels, providing more detailed tracking of metrics associated with specific projects and hostnames.
252-257: LGTM!The code changes are approved.
The addition of
hostnameandprojectparameters to theAddPushPullReceivedOperationsfunction enhances the ability to categorize and filter metrics based on these labels, providing more detailed tracking of metrics associated with specific projects and hostnames.
262-267: LGTM!The code changes are approved.
The addition of
hostnameandprojectparameters to theAddPushPullSentOperationsfunction enhances the ability to categorize and filter metrics based on these labels, providing more detailed tracking of metrics associated with specific projects and hostnames.
277-282: LGTM!The code changes are approved.
The addition of
hostnameandprojectparameters to theAddPushPullSnapshotBytesfunction enhances the ability to categorize and filter metrics based on these labels, providing more detailed tracking of metrics associated with specific projects and hostnames.
336-342: LGTM!The code changes are approved.
The addition of
hostnameandprojectparameters to theAddWatchDocumentConnectionsfunction enhances the ability to categorize and filter metrics based on these labels, providing more detailed tracking of metrics associated with specific projects and hostnames.
345-352: LGTM!The code changes are approved.
The addition of
hostnameandprojectparameters to theRemoveWatchDocumentConnectionsfunction enhances the ability to categorize and filter metrics based on these labels, providing more detailed tracking of metrics associated with specific projects and hostnames.
354-362: LGTM!The code changes are approved.
The
AddWatchDocumentEventsfunction enhances the ability to categorize and filter metrics based on thehostname,project, anddocEventTypelabels, providing more detailed tracking of events in document watch stream connections.server/rpc/yorkie_server.go (1)
592-595: LGTM!The addition of the
context.Contextparameter to theunwatchDocfunction is an improvement as it allows for better context propagation and cancellation.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Go Benchmark
| Benchmark suite | Current: 46bcc1a | Previous: 874ef57 | Ratio |
|---|---|---|---|
BenchmarkDocument/constructor_test |
1501 ns/op 1337 B/op 24 allocs/op |
1502 ns/op 1337 B/op 24 allocs/op |
1.00 |
BenchmarkDocument/constructor_test - ns/op |
1501 ns/op |
1502 ns/op |
1.00 |
BenchmarkDocument/constructor_test - B/op |
1337 B/op |
1337 B/op |
1 |
BenchmarkDocument/constructor_test - allocs/op |
24 allocs/op |
24 allocs/op |
1 |
BenchmarkDocument/status_test |
1117 ns/op 1305 B/op 22 allocs/op |
958.6 ns/op 1305 B/op 22 allocs/op |
1.17 |
BenchmarkDocument/status_test - ns/op |
1117 ns/op |
958.6 ns/op |
1.17 |
BenchmarkDocument/status_test - B/op |
1305 B/op |
1305 B/op |
1 |
BenchmarkDocument/status_test - allocs/op |
22 allocs/op |
22 allocs/op |
1 |
BenchmarkDocument/equals_test |
7630 ns/op 7273 B/op 132 allocs/op |
8839 ns/op 7273 B/op 132 allocs/op |
0.86 |
BenchmarkDocument/equals_test - ns/op |
7630 ns/op |
8839 ns/op |
0.86 |
BenchmarkDocument/equals_test - B/op |
7273 B/op |
7273 B/op |
1 |
BenchmarkDocument/equals_test - allocs/op |
132 allocs/op |
132 allocs/op |
1 |
BenchmarkDocument/nested_update_test |
16688 ns/op 12138 B/op 262 allocs/op |
16836 ns/op 12139 B/op 262 allocs/op |
0.99 |
BenchmarkDocument/nested_update_test - ns/op |
16688 ns/op |
16836 ns/op |
0.99 |
BenchmarkDocument/nested_update_test - B/op |
12138 B/op |
12139 B/op |
1.00 |
BenchmarkDocument/nested_update_test - allocs/op |
262 allocs/op |
262 allocs/op |
1 |
BenchmarkDocument/delete_test |
22342 ns/op 15363 B/op 341 allocs/op |
22791 ns/op 15363 B/op 341 allocs/op |
0.98 |
BenchmarkDocument/delete_test - ns/op |
22342 ns/op |
22791 ns/op |
0.98 |
BenchmarkDocument/delete_test - B/op |
15363 B/op |
15363 B/op |
1 |
BenchmarkDocument/delete_test - allocs/op |
341 allocs/op |
341 allocs/op |
1 |
BenchmarkDocument/object_test |
8559 ns/op 6817 B/op 120 allocs/op |
8679 ns/op 6817 B/op 120 allocs/op |
0.99 |
BenchmarkDocument/object_test - ns/op |
8559 ns/op |
8679 ns/op |
0.99 |
BenchmarkDocument/object_test - B/op |
6817 B/op |
6817 B/op |
1 |
BenchmarkDocument/object_test - allocs/op |
120 allocs/op |
120 allocs/op |
1 |
BenchmarkDocument/array_test |
29008 ns/op 11946 B/op 276 allocs/op |
29192 ns/op 11946 B/op 276 allocs/op |
0.99 |
BenchmarkDocument/array_test - ns/op |
29008 ns/op |
29192 ns/op |
0.99 |
BenchmarkDocument/array_test - B/op |
11946 B/op |
11946 B/op |
1 |
BenchmarkDocument/array_test - allocs/op |
276 allocs/op |
276 allocs/op |
1 |
BenchmarkDocument/text_test |
30481 ns/op 14715 B/op 469 allocs/op |
30685 ns/op 14715 B/op 469 allocs/op |
0.99 |
BenchmarkDocument/text_test - ns/op |
30481 ns/op |
30685 ns/op |
0.99 |
BenchmarkDocument/text_test - B/op |
14715 B/op |
14715 B/op |
1 |
BenchmarkDocument/text_test - allocs/op |
469 allocs/op |
469 allocs/op |
1 |
BenchmarkDocument/text_composition_test |
28878 ns/op 18422 B/op 484 allocs/op |
28800 ns/op 18422 B/op 484 allocs/op |
1.00 |
BenchmarkDocument/text_composition_test - ns/op |
28878 ns/op |
28800 ns/op |
1.00 |
BenchmarkDocument/text_composition_test - B/op |
18422 B/op |
18422 B/op |
1 |
BenchmarkDocument/text_composition_test - allocs/op |
484 allocs/op |
484 allocs/op |
1 |
BenchmarkDocument/rich_text_test |
80580 ns/op 38476 B/op 1148 allocs/op |
81024 ns/op 38476 B/op 1148 allocs/op |
0.99 |
BenchmarkDocument/rich_text_test - ns/op |
80580 ns/op |
81024 ns/op |
0.99 |
BenchmarkDocument/rich_text_test - B/op |
38476 B/op |
38476 B/op |
1 |
BenchmarkDocument/rich_text_test - allocs/op |
1148 allocs/op |
1148 allocs/op |
1 |
BenchmarkDocument/counter_test |
17482 ns/op 10722 B/op 244 allocs/op |
17798 ns/op 10722 B/op 244 allocs/op |
0.98 |
BenchmarkDocument/counter_test - ns/op |
17482 ns/op |
17798 ns/op |
0.98 |
BenchmarkDocument/counter_test - B/op |
10722 B/op |
10722 B/op |
1 |
BenchmarkDocument/counter_test - allocs/op |
244 allocs/op |
244 allocs/op |
1 |
BenchmarkDocument/text_edit_gc_100 |
1275598 ns/op 870962 B/op 16753 allocs/op |
1285570 ns/op 870949 B/op 16752 allocs/op |
0.99 |
BenchmarkDocument/text_edit_gc_100 - ns/op |
1275598 ns/op |
1285570 ns/op |
0.99 |
BenchmarkDocument/text_edit_gc_100 - B/op |
870962 B/op |
870949 B/op |
1.00 |
BenchmarkDocument/text_edit_gc_100 - allocs/op |
16753 allocs/op |
16752 allocs/op |
1.00 |
BenchmarkDocument/text_edit_gc_1000 |
49517633 ns/op 50535490 B/op 181710 allocs/op |
49792580 ns/op 50536338 B/op 181710 allocs/op |
0.99 |
BenchmarkDocument/text_edit_gc_1000 - ns/op |
49517633 ns/op |
49792580 ns/op |
0.99 |
BenchmarkDocument/text_edit_gc_1000 - B/op |
50535490 B/op |
50536338 B/op |
1.00 |
BenchmarkDocument/text_edit_gc_1000 - allocs/op |
181710 allocs/op |
181710 allocs/op |
1 |
BenchmarkDocument/text_split_gc_100 |
1893091 ns/op 1528808 B/op 15605 allocs/op |
1863562 ns/op 1528819 B/op 15604 allocs/op |
1.02 |
BenchmarkDocument/text_split_gc_100 - ns/op |
1893091 ns/op |
1863562 ns/op |
1.02 |
BenchmarkDocument/text_split_gc_100 - B/op |
1528808 B/op |
1528819 B/op |
1.00 |
BenchmarkDocument/text_split_gc_100 - allocs/op |
15605 allocs/op |
15604 allocs/op |
1.00 |
BenchmarkDocument/text_split_gc_1000 |
111081221 ns/op 135076795 B/op 182185 allocs/op |
111342303 ns/op 135077881 B/op 182206 allocs/op |
1.00 |
BenchmarkDocument/text_split_gc_1000 - ns/op |
111081221 ns/op |
111342303 ns/op |
1.00 |
BenchmarkDocument/text_split_gc_1000 - B/op |
135076795 B/op |
135077881 B/op |
1.00 |
BenchmarkDocument/text_split_gc_1000 - allocs/op |
182185 allocs/op |
182206 allocs/op |
1.00 |
BenchmarkDocument/text_delete_all_10000 |
16237859 ns/op 10182113 B/op 40673 allocs/op |
16086684 ns/op 10183904 B/op 40679 allocs/op |
1.01 |
BenchmarkDocument/text_delete_all_10000 - ns/op |
16237859 ns/op |
16086684 ns/op |
1.01 |
BenchmarkDocument/text_delete_all_10000 - B/op |
10182113 B/op |
10183904 B/op |
1.00 |
BenchmarkDocument/text_delete_all_10000 - allocs/op |
40673 allocs/op |
40679 allocs/op |
1.00 |
BenchmarkDocument/text_delete_all_100000 |
298504322 ns/op 142683036 B/op 411708 allocs/op |
287158914 ns/op 142677448 B/op 411669 allocs/op |
1.04 |
BenchmarkDocument/text_delete_all_100000 - ns/op |
298504322 ns/op |
287158914 ns/op |
1.04 |
BenchmarkDocument/text_delete_all_100000 - B/op |
142683036 B/op |
142677448 B/op |
1.00 |
BenchmarkDocument/text_delete_all_100000 - allocs/op |
411708 allocs/op |
411669 allocs/op |
1.00 |
BenchmarkDocument/text_100 |
222684 ns/op 120037 B/op 5081 allocs/op |
216529 ns/op 120037 B/op 5081 allocs/op |
1.03 |
BenchmarkDocument/text_100 - ns/op |
222684 ns/op |
216529 ns/op |
1.03 |
BenchmarkDocument/text_100 - B/op |
120037 B/op |
120037 B/op |
1 |
BenchmarkDocument/text_100 - allocs/op |
5081 allocs/op |
5081 allocs/op |
1 |
BenchmarkDocument/text_1000 |
2395237 ns/op 1169026 B/op 50085 allocs/op |
2347773 ns/op 1169023 B/op 50085 allocs/op |
1.02 |
BenchmarkDocument/text_1000 - ns/op |
2395237 ns/op |
2347773 ns/op |
1.02 |
BenchmarkDocument/text_1000 - B/op |
1169026 B/op |
1169023 B/op |
1.00 |
BenchmarkDocument/text_1000 - allocs/op |
50085 allocs/op |
50085 allocs/op |
1 |
BenchmarkDocument/array_1000 |
1266275 ns/op 1091393 B/op 11832 allocs/op |
1256686 ns/op 1091453 B/op 11832 allocs/op |
1.01 |
BenchmarkDocument/array_1000 - ns/op |
1266275 ns/op |
1256686 ns/op |
1.01 |
BenchmarkDocument/array_1000 - B/op |
1091393 B/op |
1091453 B/op |
1.00 |
BenchmarkDocument/array_1000 - allocs/op |
11832 allocs/op |
11832 allocs/op |
1 |
BenchmarkDocument/array_10000 |
13141617 ns/op 9800379 B/op 120299 allocs/op |
13254373 ns/op 9799926 B/op 120296 allocs/op |
0.99 |
BenchmarkDocument/array_10000 - ns/op |
13141617 ns/op |
13254373 ns/op |
0.99 |
BenchmarkDocument/array_10000 - B/op |
9800379 B/op |
9799926 B/op |
1.00 |
BenchmarkDocument/array_10000 - allocs/op |
120299 allocs/op |
120296 allocs/op |
1.00 |
BenchmarkDocument/array_gc_100 |
154913 ns/op 132700 B/op 1260 allocs/op |
154990 ns/op 132728 B/op 1261 allocs/op |
1.00 |
BenchmarkDocument/array_gc_100 - ns/op |
154913 ns/op |
154990 ns/op |
1.00 |
BenchmarkDocument/array_gc_100 - B/op |
132700 B/op |
132728 B/op |
1.00 |
BenchmarkDocument/array_gc_100 - allocs/op |
1260 allocs/op |
1261 allocs/op |
1.00 |
BenchmarkDocument/array_gc_1000 |
1451383 ns/op 1159141 B/op 12877 allocs/op |
1457162 ns/op 1159141 B/op 12876 allocs/op |
1.00 |
BenchmarkDocument/array_gc_1000 - ns/op |
1451383 ns/op |
1457162 ns/op |
1.00 |
BenchmarkDocument/array_gc_1000 - B/op |
1159141 B/op |
1159141 B/op |
1 |
BenchmarkDocument/array_gc_1000 - allocs/op |
12877 allocs/op |
12876 allocs/op |
1.00 |
BenchmarkDocument/counter_1000 |
210526 ns/op 193081 B/op 5771 allocs/op |
208931 ns/op 193081 B/op 5771 allocs/op |
1.01 |
BenchmarkDocument/counter_1000 - ns/op |
210526 ns/op |
208931 ns/op |
1.01 |
BenchmarkDocument/counter_1000 - B/op |
193081 B/op |
193081 B/op |
1 |
BenchmarkDocument/counter_1000 - allocs/op |
5771 allocs/op |
5771 allocs/op |
1 |
BenchmarkDocument/counter_10000 |
2197500 ns/op 2087981 B/op 59778 allocs/op |
2196593 ns/op 2087996 B/op 59778 allocs/op |
1.00 |
BenchmarkDocument/counter_10000 - ns/op |
2197500 ns/op |
2196593 ns/op |
1.00 |
BenchmarkDocument/counter_10000 - B/op |
2087981 B/op |
2087996 B/op |
1.00 |
BenchmarkDocument/counter_10000 - allocs/op |
59778 allocs/op |
59778 allocs/op |
1 |
BenchmarkDocument/object_1000 |
1457120 ns/op 1428142 B/op 9849 allocs/op |
1445136 ns/op 1428118 B/op 9849 allocs/op |
1.01 |
BenchmarkDocument/object_1000 - ns/op |
1457120 ns/op |
1445136 ns/op |
1.01 |
BenchmarkDocument/object_1000 - B/op |
1428142 B/op |
1428118 B/op |
1.00 |
BenchmarkDocument/object_1000 - allocs/op |
9849 allocs/op |
9849 allocs/op |
1 |
BenchmarkDocument/object_10000 |
15437380 ns/op 12168409 B/op 100568 allocs/op |
15229325 ns/op 12167169 B/op 100566 allocs/op |
1.01 |
BenchmarkDocument/object_10000 - ns/op |
15437380 ns/op |
15229325 ns/op |
1.01 |
BenchmarkDocument/object_10000 - B/op |
12168409 B/op |
12167169 B/op |
1.00 |
BenchmarkDocument/object_10000 - allocs/op |
100568 allocs/op |
100566 allocs/op |
1.00 |
BenchmarkDocument/tree_100 |
1061066 ns/op 943702 B/op 6101 allocs/op |
1036989 ns/op 943702 B/op 6101 allocs/op |
1.02 |
BenchmarkDocument/tree_100 - ns/op |
1061066 ns/op |
1036989 ns/op |
1.02 |
BenchmarkDocument/tree_100 - B/op |
943702 B/op |
943702 B/op |
1 |
BenchmarkDocument/tree_100 - allocs/op |
6101 allocs/op |
6101 allocs/op |
1 |
BenchmarkDocument/tree_1000 |
78862637 ns/op 86460444 B/op 60115 allocs/op |
75935430 ns/op 86460380 B/op 60115 allocs/op |
1.04 |
BenchmarkDocument/tree_1000 - ns/op |
78862637 ns/op |
75935430 ns/op |
1.04 |
BenchmarkDocument/tree_1000 - B/op |
86460444 B/op |
86460380 B/op |
1.00 |
BenchmarkDocument/tree_1000 - allocs/op |
60115 allocs/op |
60115 allocs/op |
1 |
BenchmarkDocument/tree_10000 |
9654353082 ns/op 8580667584 B/op 600211 allocs/op |
9453226510 ns/op 8580660272 B/op 600206 allocs/op |
1.02 |
BenchmarkDocument/tree_10000 - ns/op |
9654353082 ns/op |
9453226510 ns/op |
1.02 |
BenchmarkDocument/tree_10000 - B/op |
8580667584 B/op |
8580660272 B/op |
1.00 |
BenchmarkDocument/tree_10000 - allocs/op |
600211 allocs/op |
600206 allocs/op |
1.00 |
BenchmarkDocument/tree_delete_all_1000 |
79258738 ns/op 87510466 B/op 75266 allocs/op |
77686870 ns/op 87511005 B/op 75267 allocs/op |
1.02 |
BenchmarkDocument/tree_delete_all_1000 - ns/op |
79258738 ns/op |
77686870 ns/op |
1.02 |
BenchmarkDocument/tree_delete_all_1000 - B/op |
87510466 B/op |
87511005 B/op |
1.00 |
BenchmarkDocument/tree_delete_all_1000 - allocs/op |
75266 allocs/op |
75267 allocs/op |
1.00 |
BenchmarkDocument/tree_edit_gc_100 |
4001902 ns/op 4146923 B/op 15141 allocs/op |
3854048 ns/op 4147807 B/op 15141 allocs/op |
1.04 |
BenchmarkDocument/tree_edit_gc_100 - ns/op |
4001902 ns/op |
3854048 ns/op |
1.04 |
BenchmarkDocument/tree_edit_gc_100 - B/op |
4146923 B/op |
4147807 B/op |
1.00 |
BenchmarkDocument/tree_edit_gc_100 - allocs/op |
15141 allocs/op |
15141 allocs/op |
1 |
BenchmarkDocument/tree_edit_gc_1000 |
319633478 ns/op 383746726 B/op 154869 allocs/op |
308716340 ns/op 383747112 B/op 154859 allocs/op |
1.04 |
BenchmarkDocument/tree_edit_gc_1000 - ns/op |
319633478 ns/op |
308716340 ns/op |
1.04 |
BenchmarkDocument/tree_edit_gc_1000 - B/op |
383746726 B/op |
383747112 B/op |
1.00 |
BenchmarkDocument/tree_edit_gc_1000 - allocs/op |
154869 allocs/op |
154859 allocs/op |
1.00 |
BenchmarkDocument/tree_split_gc_100 |
2644884 ns/op 2412591 B/op 11125 allocs/op |
2564905 ns/op 2412509 B/op 11125 allocs/op |
1.03 |
BenchmarkDocument/tree_split_gc_100 - ns/op |
2644884 ns/op |
2564905 ns/op |
1.03 |
BenchmarkDocument/tree_split_gc_100 - B/op |
2412591 B/op |
2412509 B/op |
1.00 |
BenchmarkDocument/tree_split_gc_100 - allocs/op |
11125 allocs/op |
11125 allocs/op |
1 |
BenchmarkDocument/tree_split_gc_1000 |
194517648 ns/op 222251421 B/op 122004 allocs/op |
185618715 ns/op 222249102 B/op 121990 allocs/op |
1.05 |
BenchmarkDocument/tree_split_gc_1000 - ns/op |
194517648 ns/op |
185618715 ns/op |
1.05 |
BenchmarkDocument/tree_split_gc_1000 - B/op |
222251421 B/op |
222249102 B/op |
1.00 |
BenchmarkDocument/tree_split_gc_1000 - allocs/op |
122004 allocs/op |
121990 allocs/op |
1.00 |
BenchmarkRPC/client_to_server |
346546897 ns/op 17682816 B/op 169231 allocs/op |
348103783 ns/op 16593624 B/op 169202 allocs/op |
1.00 |
BenchmarkRPC/client_to_server - ns/op |
346546897 ns/op |
348103783 ns/op |
1.00 |
BenchmarkRPC/client_to_server - B/op |
17682816 B/op |
16593624 B/op |
1.07 |
BenchmarkRPC/client_to_server - allocs/op |
169231 allocs/op |
169202 allocs/op |
1.00 |
BenchmarkRPC/client_to_client_via_server |
632995776 ns/op 32378312 B/op 324161 allocs/op |
640784350 ns/op 34045184 B/op 324561 allocs/op |
0.99 |
BenchmarkRPC/client_to_client_via_server - ns/op |
632995776 ns/op |
640784350 ns/op |
0.99 |
BenchmarkRPC/client_to_client_via_server - B/op |
32378312 B/op |
34045184 B/op |
0.95 |
BenchmarkRPC/client_to_client_via_server - allocs/op |
324161 allocs/op |
324561 allocs/op |
1.00 |
BenchmarkRPC/attach_large_document |
1335032167 ns/op 1896314792 B/op 8840 allocs/op |
1370152717 ns/op 1919873608 B/op 8873 allocs/op |
0.97 |
BenchmarkRPC/attach_large_document - ns/op |
1335032167 ns/op |
1370152717 ns/op |
0.97 |
BenchmarkRPC/attach_large_document - B/op |
1896314792 B/op |
1919873608 B/op |
0.99 |
BenchmarkRPC/attach_large_document - allocs/op |
8840 allocs/op |
8873 allocs/op |
1.00 |
BenchmarkRPC/adminCli_to_server |
559986852 ns/op 35966724 B/op 289549 allocs/op |
550455462 ns/op 35966036 B/op 289555 allocs/op |
1.02 |
BenchmarkRPC/adminCli_to_server - ns/op |
559986852 ns/op |
550455462 ns/op |
1.02 |
BenchmarkRPC/adminCli_to_server - B/op |
35966724 B/op |
35966036 B/op |
1.00 |
BenchmarkRPC/adminCli_to_server - allocs/op |
289549 allocs/op |
289555 allocs/op |
1.00 |
BenchmarkLocker |
64.1 ns/op 16 B/op 1 allocs/op |
64.39 ns/op 16 B/op 1 allocs/op |
1.00 |
BenchmarkLocker - ns/op |
64.1 ns/op |
64.39 ns/op |
1.00 |
BenchmarkLocker - B/op |
16 B/op |
16 B/op |
1 |
BenchmarkLocker - allocs/op |
1 allocs/op |
1 allocs/op |
1 |
BenchmarkLockerParallel |
39.24 ns/op 0 B/op 0 allocs/op |
39.31 ns/op 0 B/op 0 allocs/op |
1.00 |
BenchmarkLockerParallel - ns/op |
39.24 ns/op |
39.31 ns/op |
1.00 |
BenchmarkLockerParallel - B/op |
0 B/op |
0 B/op |
1 |
BenchmarkLockerParallel - allocs/op |
0 allocs/op |
0 allocs/op |
1 |
BenchmarkLockerMoreKeys |
155 ns/op 15 B/op 0 allocs/op |
145.3 ns/op 15 B/op 0 allocs/op |
1.07 |
BenchmarkLockerMoreKeys - ns/op |
155 ns/op |
145.3 ns/op |
1.07 |
BenchmarkLockerMoreKeys - B/op |
15 B/op |
15 B/op |
1 |
BenchmarkLockerMoreKeys - allocs/op |
0 allocs/op |
0 allocs/op |
1 |
BenchmarkChange/Push_10_Changes |
3636127 ns/op 118047 B/op 1215 allocs/op |
3644411 ns/op 118236 B/op 1215 allocs/op |
1.00 |
BenchmarkChange/Push_10_Changes - ns/op |
3636127 ns/op |
3644411 ns/op |
1.00 |
BenchmarkChange/Push_10_Changes - B/op |
118047 B/op |
118236 B/op |
1.00 |
BenchmarkChange/Push_10_Changes - allocs/op |
1215 allocs/op |
1215 allocs/op |
1 |
BenchmarkChange/Push_100_Changes |
14395672 ns/op 571450 B/op 6586 allocs/op |
14303508 ns/op 570143 B/op 6585 allocs/op |
1.01 |
BenchmarkChange/Push_100_Changes - ns/op |
14395672 ns/op |
14303508 ns/op |
1.01 |
BenchmarkChange/Push_100_Changes - B/op |
571450 B/op |
570143 B/op |
1.00 |
BenchmarkChange/Push_100_Changes - allocs/op |
6586 allocs/op |
6585 allocs/op |
1.00 |
BenchmarkChange/Push_1000_Changes |
117055777 ns/op 5316742 B/op 63078 allocs/op |
116977747 ns/op 5347681 B/op 63079 allocs/op |
1.00 |
BenchmarkChange/Push_1000_Changes - ns/op |
117055777 ns/op |
116977747 ns/op |
1.00 |
BenchmarkChange/Push_1000_Changes - B/op |
5316742 B/op |
5347681 B/op |
0.99 |
BenchmarkChange/Push_1000_Changes - allocs/op |
63078 allocs/op |
63079 allocs/op |
1.00 |
BenchmarkChange/Pull_10_Changes |
2944019 ns/op 103116 B/op 1018 allocs/op |
2984957 ns/op 102883 B/op 1018 allocs/op |
0.99 |
BenchmarkChange/Pull_10_Changes - ns/op |
2944019 ns/op |
2984957 ns/op |
0.99 |
BenchmarkChange/Pull_10_Changes - B/op |
103116 B/op |
102883 B/op |
1.00 |
BenchmarkChange/Pull_10_Changes - allocs/op |
1018 allocs/op |
1018 allocs/op |
1 |
BenchmarkChange/Pull_100_Changes |
4414220 ns/op 268228 B/op 3489 allocs/op |
4420783 ns/op 267850 B/op 3489 allocs/op |
1.00 |
BenchmarkChange/Pull_100_Changes - ns/op |
4414220 ns/op |
4420783 ns/op |
1.00 |
BenchmarkChange/Pull_100_Changes - B/op |
268228 B/op |
267850 B/op |
1.00 |
BenchmarkChange/Pull_100_Changes - allocs/op |
3489 allocs/op |
3489 allocs/op |
1 |
BenchmarkChange/Pull_1000_Changes |
8774972 ns/op 1495487 B/op 29869 allocs/op |
8851407 ns/op 1492198 B/op 29862 allocs/op |
0.99 |
BenchmarkChange/Pull_1000_Changes - ns/op |
8774972 ns/op |
8851407 ns/op |
0.99 |
BenchmarkChange/Pull_1000_Changes - B/op |
1495487 B/op |
1492198 B/op |
1.00 |
BenchmarkChange/Pull_1000_Changes - allocs/op |
29869 allocs/op |
29862 allocs/op |
1.00 |
BenchmarkSnapshot/Push_3KB_snapshot |
16840450 ns/op 714586 B/op 6587 allocs/op |
17085850 ns/op 713215 B/op 6588 allocs/op |
0.99 |
BenchmarkSnapshot/Push_3KB_snapshot - ns/op |
16840450 ns/op |
17085850 ns/op |
0.99 |
BenchmarkSnapshot/Push_3KB_snapshot - B/op |
714586 B/op |
713215 B/op |
1.00 |
BenchmarkSnapshot/Push_3KB_snapshot - allocs/op |
6587 allocs/op |
6588 allocs/op |
1.00 |
BenchmarkSnapshot/Push_30KB_snapshot |
119953178 ns/op 5561765 B/op 63078 allocs/op |
121177145 ns/op 5655982 B/op 63082 allocs/op |
0.99 |
BenchmarkSnapshot/Push_30KB_snapshot - ns/op |
119953178 ns/op |
121177145 ns/op |
0.99 |
BenchmarkSnapshot/Push_30KB_snapshot - B/op |
5561765 B/op |
5655982 B/op |
0.98 |
BenchmarkSnapshot/Push_30KB_snapshot - allocs/op |
63078 allocs/op |
63082 allocs/op |
1.00 |
BenchmarkSnapshot/Pull_3KB_snapshot |
6503603 ns/op 923963 B/op 15524 allocs/op |
6520531 ns/op 923461 B/op 15525 allocs/op |
1.00 |
BenchmarkSnapshot/Pull_3KB_snapshot - ns/op |
6503603 ns/op |
6520531 ns/op |
1.00 |
BenchmarkSnapshot/Pull_3KB_snapshot - B/op |
923963 B/op |
923461 B/op |
1.00 |
BenchmarkSnapshot/Pull_3KB_snapshot - allocs/op |
15524 allocs/op |
15525 allocs/op |
1.00 |
BenchmarkSnapshot/Pull_30KB_snapshot |
15200430 ns/op 7157662 B/op 150116 allocs/op |
15256779 ns/op 7157880 B/op 150120 allocs/op |
1.00 |
BenchmarkSnapshot/Pull_30KB_snapshot - ns/op |
15200430 ns/op |
15256779 ns/op |
1.00 |
BenchmarkSnapshot/Pull_30KB_snapshot - B/op |
7157662 B/op |
7157880 B/op |
1.00 |
BenchmarkSnapshot/Pull_30KB_snapshot - allocs/op |
150116 allocs/op |
150120 allocs/op |
1.00 |
BenchmarkSync/memory_sync_10_test |
7938 ns/op 1286 B/op 38 allocs/op |
6900 ns/op 1286 B/op 38 allocs/op |
1.15 |
BenchmarkSync/memory_sync_10_test - ns/op |
7938 ns/op |
6900 ns/op |
1.15 |
BenchmarkSync/memory_sync_10_test - B/op |
1286 B/op |
1286 B/op |
1 |
BenchmarkSync/memory_sync_10_test - allocs/op |
38 allocs/op |
38 allocs/op |
1 |
BenchmarkSync/memory_sync_100_test |
49443 ns/op 9013 B/op 296 allocs/op |
51321 ns/op 8642 B/op 273 allocs/op |
0.96 |
BenchmarkSync/memory_sync_100_test - ns/op |
49443 ns/op |
51321 ns/op |
0.96 |
BenchmarkSync/memory_sync_100_test - B/op |
9013 B/op |
8642 B/op |
1.04 |
BenchmarkSync/memory_sync_100_test - allocs/op |
296 allocs/op |
273 allocs/op |
1.08 |
BenchmarkSync/memory_sync_1000_test |
554778 ns/op 75699 B/op 2207 allocs/op |
590747 ns/op 73993 B/op 2098 allocs/op |
0.94 |
BenchmarkSync/memory_sync_1000_test - ns/op |
554778 ns/op |
590747 ns/op |
0.94 |
BenchmarkSync/memory_sync_1000_test - B/op |
75699 B/op |
73993 B/op |
1.02 |
BenchmarkSync/memory_sync_1000_test - allocs/op |
2207 allocs/op |
2098 allocs/op |
1.05 |
BenchmarkSync/memory_sync_10000_test |
7302172 ns/op 737633 B/op 20285 allocs/op |
7250593 ns/op 746753 B/op 20441 allocs/op |
1.01 |
BenchmarkSync/memory_sync_10000_test - ns/op |
7302172 ns/op |
7250593 ns/op |
1.01 |
BenchmarkSync/memory_sync_10000_test - B/op |
737633 B/op |
746753 B/op |
0.99 |
BenchmarkSync/memory_sync_10000_test - allocs/op |
20285 allocs/op |
20441 allocs/op |
0.99 |
BenchmarkTextEditing |
5182335820 ns/op 3901898224 B/op 18743133 allocs/op |
5286678476 ns/op 3901937088 B/op 18743228 allocs/op |
0.98 |
BenchmarkTextEditing - ns/op |
5182335820 ns/op |
5286678476 ns/op |
0.98 |
BenchmarkTextEditing - B/op |
3901898224 B/op |
3901937088 B/op |
1.00 |
BenchmarkTextEditing - allocs/op |
18743133 allocs/op |
18743228 allocs/op |
1.00 |
BenchmarkTree/10000_vertices_to_protobuf |
3434955 ns/op 6262996 B/op 70025 allocs/op |
3666561 ns/op 6262996 B/op 70025 allocs/op |
0.94 |
BenchmarkTree/10000_vertices_to_protobuf - ns/op |
3434955 ns/op |
3666561 ns/op |
0.94 |
BenchmarkTree/10000_vertices_to_protobuf - B/op |
6262996 B/op |
6262996 B/op |
1 |
BenchmarkTree/10000_vertices_to_protobuf - allocs/op |
70025 allocs/op |
70025 allocs/op |
1 |
BenchmarkTree/10000_vertices_from_protobuf |
153323836 ns/op 442171650 B/op 290052 allocs/op |
161253482 ns/op 442172638 B/op 290039 allocs/op |
0.95 |
BenchmarkTree/10000_vertices_from_protobuf - ns/op |
153323836 ns/op |
161253482 ns/op |
0.95 |
BenchmarkTree/10000_vertices_from_protobuf - B/op |
442171650 B/op |
442172638 B/op |
1.00 |
BenchmarkTree/10000_vertices_from_protobuf - allocs/op |
290052 allocs/op |
290039 allocs/op |
1.00 |
BenchmarkTree/20000_vertices_to_protobuf |
7866777 ns/op 12716975 B/op 140028 allocs/op |
7816492 ns/op 12716918 B/op 140028 allocs/op |
1.01 |
BenchmarkTree/20000_vertices_to_protobuf - ns/op |
7866777 ns/op |
7816492 ns/op |
1.01 |
BenchmarkTree/20000_vertices_to_protobuf - B/op |
12716975 B/op |
12716918 B/op |
1.00 |
BenchmarkTree/20000_vertices_to_protobuf - allocs/op |
140028 allocs/op |
140028 allocs/op |
1 |
BenchmarkTree/20000_vertices_from_protobuf |
700103595 ns/op 1697272344 B/op 580088 allocs/op |
689704450 ns/op 1697271976 B/op 580043 allocs/op |
1.02 |
BenchmarkTree/20000_vertices_from_protobuf - ns/op |
700103595 ns/op |
689704450 ns/op |
1.02 |
BenchmarkTree/20000_vertices_from_protobuf - B/op |
1697272344 B/op |
1697271976 B/op |
1.00 |
BenchmarkTree/20000_vertices_from_protobuf - allocs/op |
580088 allocs/op |
580043 allocs/op |
1.00 |
BenchmarkTree/30000_vertices_to_protobuf |
12320707 ns/op 19318327 B/op 210030 allocs/op |
12504859 ns/op 19318336 B/op 210031 allocs/op |
0.99 |
BenchmarkTree/30000_vertices_to_protobuf - ns/op |
12320707 ns/op |
12504859 ns/op |
0.99 |
BenchmarkTree/30000_vertices_to_protobuf - B/op |
19318327 B/op |
19318336 B/op |
1.00 |
BenchmarkTree/30000_vertices_to_protobuf - allocs/op |
210030 allocs/op |
210031 allocs/op |
1.00 |
BenchmarkTree/30000_vertices_from_protobuf |
1647020785 ns/op 3752043928 B/op 870046 allocs/op |
1670053024 ns/op 3752052408 B/op 870049 allocs/op |
0.99 |
BenchmarkTree/30000_vertices_from_protobuf - ns/op |
1647020785 ns/op |
1670053024 ns/op |
0.99 |
BenchmarkTree/30000_vertices_from_protobuf - B/op |
3752043928 B/op |
3752052408 B/op |
1.00 |
BenchmarkTree/30000_vertices_from_protobuf - allocs/op |
870046 allocs/op |
870049 allocs/op |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
- Coverage 50.80% 50.75% -0.06%
==========================================
Files 73 74 +1
Lines 10865 10888 +23
==========================================
+ Hits 5520 5526 +6
- Misses 4796 4813 +17
Partials 549 549 ☔ View full report in Codecov by Sentry. |
hackerwins
approved these changes
Sep 11, 2024
hackerwins
changed the title
hackerwins
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add project label and hostname label in pushpull metric
Add event count and payload bytes of watch document metric.
Which issue(s) this PR fixes:
Address #984
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist:
Summary by CodeRabbit
New Features
Improvements
Bug Fixes