Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protocol to support multi-user undo and redo on Text.edit #644

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

hyemmie
Copy link
Contributor

@hyemmie hyemmie commented Sep 15, 2023

What this PR does / why we need it: A new operation, EditReverse, is proposed to support multi-user undo and redo functionality in text.edit. (yorkie-team/yorkie-js-sdk#635)
To support this, the server also needs to modify the protocol buffer. This PR defines the new EditReverse operation and modifies the protocol buffer to allow replicas to send and receive EditReverse operations.

Which issue(s) this PR fixes:

It fixs #49 partially.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@hyemmie hyemmie added enhancement 🌟 New feature or request protocol changed 📝 Whether the protocol has changed labels Sep 15, 2023
@hyemmie hyemmie self-assigned this Sep 15, 2023
@hyemmie hyemmie mentioned this pull request Sep 15, 2023
2 tasks
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.28% ⚠️

Comparison is base (940941a) 49.47% compared to head (57e196e) 49.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
- Coverage   49.47%   49.19%   -0.28%     
==========================================
  Files          69       69              
  Lines        9951    10007      +56     
==========================================
  Hits         4923     4923              
- Misses       4512     4568      +56     
  Partials      516      516              
Files Changed Coverage Δ
api/converter/from_pb.go 40.08% <0.00%> (-2.02%) ⬇️
api/converter/to_pb.go 50.00% <0.00%> (-2.75%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyemmie hyemmie marked this pull request as ready for review September 15, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request protocol changed 📝 Whether the protocol has changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants