Wu22e save rpc addr to context #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The figure explains that there is a problem when deleting S3, not S2
Signed-off-by: Sion Kang <siontama@gmail.com>
Currently, we are unable to check for concurrent cases when applying the Text.setStyle operation. This pull request introduces a map called latestCreatedAtMapByActor to track the causality between the operations of the two clients and ensures that the results converge into one.
hackerwins
force-pushed
the
Wu22e-save-rpc-addr-to-context
branch
2 times, most recently
from
78b551e
to
ce09f17
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
=======================================
Coverage 49.38% 49.38%
=======================================
Files 69 69
Lines 9964 9964
=======================================
Hits 4921 4921
Misses 4523 4523
Partials 520 520 ☔ View full report in Codecov by Sentry. |
hackerwins
force-pushed
the
Wu22e-save-rpc-addr-to-context
branch
from
ce09f17
to
8db114a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a PR for revising the codes included in #592.
This commit introduces context commands to the CLI, making it easier
to use CLI commands. When users log in to the Yorkie server, the
system now stores their context in the ~/.yorkie/config.json file.
This means that after logging in, users no longer need to specify the
rpcAddr parameter in each command, as the commands will automatically
retrieve the necessary authentication information from the config file.
Which issue(s) this PR fixes:
Fixes #544
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: