DARK:Enhance Value Checking Mechanism in Filter Processing #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses two main issues in our filter processing:
processing enum integer values, especially when 0 is a valid enum.
intentional and should be supported.
Outcome:
QA
Run the following :
./vendor/bin/pest Tests/QueryFilterTest.php
does 0 as filters[field] value supported
context function check if 0 supported, before this change when you have value =0 then $queryFilter->getField() = null