Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

Create madoka yabuuchi #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create madoka yabuuchi #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions waifus/madoka yabuuchi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add .json to the end of the filename

"type" : 0,
"english-name" : "Madoka yabuuchi",
"image" : "https://cdn.myanimelist.net/images/characters/8/379321.jpg",
"japanese-name" : "藪内 円",
"year" : 2019,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this number come from? You need to say where this number comes from in the notes. Here's an example of some notes

is-your-waifu-legal/waifus/sucy manbavaran.json

Lines 10 to 12 in 92ea548

"notes": [
"Spoilers: Both Chariot and Croix went to class together. In episode 15, Croix graduated from Luna Nova in 2007. In episode 23, we see that Chariot preformed while she was still in school. By knowing that, the last performance has to be in or before 2007, when they graduated. 2007 + 10 years is 2017. Meaning the story takes place during 2017 or earlier. Her age during the first episode is 16. 2017 - 16 years is 2001."
],

"month" : 08,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is invalid JSON, the JSON parser doesn't understand what 08 means. Replace this with 8.

"day-of-month" : 31,
"age-in-show": 16,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here, you don't have any sources that say that she's 16 during the show.

"sources" : ["https://myanimelist.net/character/80405/Madoka_Yabuuchi"]
}