-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#13] HandyFab 생성 #16
Open
wjdalswl
wants to merge
1
commit into
main
Choose a base branch
from
feature/#13
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
@wjdalswl 마이님! 제가 피그마 확인해보니 icon 색상이 |
lygon55555
reviewed
Sep 9, 2024
Comment on lines
+16
to
+46
*/ | ||
@Invalidating(.layout, .display) public var isDisabled: Bool = false { | ||
didSet { | ||
setConfiguration() | ||
} | ||
} | ||
|
||
/** | ||
Fab 버튼의 Pressed / Hover 여부를 나타낼 때 사용합니다. | ||
*/ | ||
public override var isHighlighted: Bool { | ||
didSet { setConfiguration() } | ||
} | ||
|
||
/** | ||
Fab 버튼의 타입을 결정할 때 사용합니다. | ||
*/ | ||
@Invalidating(.layout, .display) public var type: FabType = .primary { | ||
didSet { | ||
setConfiguration() | ||
} | ||
} | ||
|
||
/** | ||
Fab 버튼의 크기를 결정할 때 사용합니다. | ||
*/ | ||
@Invalidating(.layout, .display) public var size: FabSize = .large { | ||
didSet { | ||
setConfiguration() | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Invalidating
은 왜 사용하셨는지 궁금합니다!
수고하셨습니다 :) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
HandyFab를 생성했습니다.
✍️ Description
💡 PR Point
다른 브랜치에서 HandyIcon 파일을 만드셨길래, 아직 icon 작업은 하지 않았습니다!
지금은 setConfiguration() 안에 size설정, cornerRadius 설정, 아이콘 설정, state변화에 따른 색상변화 등을 모두 한 곳에 넣어두었는데, 분리를 하는게 좋을지 고민입니다.
🔥 Test
2024-08-09.7.09.48.mov
icon 컬러로
HandySemantic.iconBasicSecondary
를 사용하였는데, 피그마와 색상이 다른 것 같다고 느꼈습니다! 변경이 필요한 부분이라면 말씀해주세요!