Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#254] dark mode color 버그 수정 #256

Merged
merged 2 commits into from
Dec 27, 2023
Merged

[#254] dark mode color 버그 수정 #256

merged 2 commits into from
Dec 27, 2023

Conversation

chongin12
Copy link
Contributor

📌 Summary

dark mode color 버그 수정했습니다.
아직은 SwiftUI에서 Color 자체를 dynamic으로 설정하는 기능이 없어보입니다.
추후 Mac이나 다른 프레임워크를 지원할 때 해당 프레임워크의 dynamic provider를 사용하면 될 것 같습니다.

✍️ Description

💡 PR Point

📚 Reference

🔥 Test

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-12-26.at.20.31.55.mp4

@chongin12 chongin12 added the fix 🛠 버그, 오류 해결 label Dec 26, 2023
@chongin12 chongin12 self-assigned this Dec 26, 2023
Copy link
Contributor

@JJongW JJongW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요!

@chongin12 chongin12 merged commit 49bb9f5 into main Dec 27, 2023
@chongin12 chongin12 deleted the fix/#254 branch December 27, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🛠 버그, 오류 해결
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants