-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added decimal handling for airdrop #446
Conversation
cant we do this on the frontend? |
i'd prefer backend takes e8s from the frontend, its uniform and you dont need to handle the decimals, just update the max amount. SNS canisters have 8 decimals so the max amount can be constant |
I dont think we can because if someone tends to call this function not via our frontend we won't be able to impose the 100 to 1000 token request limit |
the max amount in the function can just be in e8s instead of looking up the decimals |
Accha so you want me to hardcode the limits to 10_000_000_000 basically 10010^8 which was previously 100 10^decimals |
What is this solving? |
Basically earlier we were sending 100 e8s in the request airdrop while integrating it in the frontend we decided to to not use 100e8s but 100*10^8 e8s (100 tokens) so to facilitate that a change was needed to update the limits ie multiplying all the limits by 10^8... |
…d-canister into airdrop_amt_fix
To check the status of the deployment
To test the platform orchestrator, you can use the following command:
dfx canister call --query 74zq4-iqaaa-aaaam-ab53a-cai get_subnet_last_upgrade_status --network=ic
the canister id (74zq4-iqaaa-aaaam-ab53a-cai) is taken from the canister_ids.json file