Skip to content

Commit

Permalink
remove magic numbers with correct sizeof
Browse files Browse the repository at this point in the history
  • Loading branch information
yrutschle committed Aug 31, 2023
1 parent 1f0cab2 commit 1fb888b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions probe.c
Original file line number Diff line number Diff line change
Expand Up @@ -173,13 +173,13 @@ static int is_openvpn_protocol (const char*p,ssize_t len, struct sslhcfg_protoco
* whereas the packet id is increased with every transmitted datagram.
*/

if (len <= OVPN_HARD_RESET_PACKET_ID_OFFSET(OVPN_HMAC_128) + 4)
if (len <= OVPN_HARD_RESET_PACKET_ID_OFFSET(OVPN_HMAC_128) + sizeof(uint32_t))
return PROBE_NEXT;

if (ntohl(*(uint32_t*)(p + OVPN_HARD_RESET_PACKET_ID_OFFSET(OVPN_HMAC_128))) <= 5u)
return PROBE_MATCH;

if (len <= OVPN_HARD_RESET_PACKET_ID_OFFSET(OVPN_HMAC_160) + 4)
if (len <= OVPN_HARD_RESET_PACKET_ID_OFFSET(OVPN_HMAC_160) + sizeof(uint32_t))
return PROBE_NEXT;

if (ntohl(*(uint32_t*)(p + OVPN_HARD_RESET_PACKET_ID_OFFSET(OVPN_HMAC_160))) <= 5u)
Expand Down

0 comments on commit 1fb888b

Please sign in to comment.