Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: ipv6 transparent patch #392

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Docker: ipv6 transparent patch #392

merged 4 commits into from
Aug 10, 2023

Conversation

klementng
Copy link
Contributor

Fix for #390.

Changes:

  • Add checking if ipv6 is enabled before implementing the ip6tables rules

@klementng klementng changed the title Docker transparent patch Docker: ipv6 transparent patch Aug 9, 2023
@yrutschle
Copy link
Owner

I see your commit makes the checks fail. I don't see why (I don't really follow the docker stuff, but apparently the build chokes on conf2struct being not present, which seems independant from your changes). I also didn't really follow how the checks work...
I'll hold on merging this until I get to look at the build actions, just in case...

@yrutschle
Copy link
Owner

I just realised this is most likely issue #283. I'll merge.

@yrutschle yrutschle merged commit 4728730 into yrutschle:master Aug 10, 2023
1 check failed
@klementng
Copy link
Contributor Author

Yeah it has happened to me a few times before when I was building it locally. I usually resolve it by clearing the docker build cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants