Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: require Cython 3.0.3 to fix known issues on CPython 3.12 #4687

Merged
merged 1 commit into from
Oct 10, 2023
Merged

BLD: require Cython 3.0.3 to fix known issues on CPython 3.12 #4687

merged 1 commit into from
Oct 10, 2023

Conversation

neutrinoceros
Copy link
Member

close #4675

@neutrinoceros neutrinoceros added bug dependencies Pull requests that update a dependency file build related to the build process tests: running tests Issues with the test setup labels Oct 5, 2023
@neutrinoceros neutrinoceros added this to the 4.3.0 milestone Oct 5, 2023
@neutrinoceros neutrinoceros marked this pull request as ready for review October 5, 2023 16:33
chrishavlin
chrishavlin previously approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@chrishavlin chrishavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Since this PR also introduces a minimal unit test with 3.12, it might be useful to add a new issue just to track the progress of moving to full testing with 3.12 (if there's not already one that I've missed). What do you think?

@neutrinoceros
Copy link
Member Author

I think this could be useful, though we're almost there already, and it looks like our optional dependencies are moving much faster than in recent years, so I'm actually hopeful that we can just finish it in a couple days.

@neutrinoceros neutrinoceros mentioned this pull request Oct 6, 2023
Closed
5 tasks
@neutrinoceros neutrinoceros changed the title BLD: require Cython 3.0.3 to fix known issues on Python 3.12 BLD: require Cython 3.0.3 to fix known issues on CPython 3.12 Oct 6, 2023
@neutrinoceros
Copy link
Member Author

@chrishavlin I've opened #4689 and linked to it here

cphyc
cphyc approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@cphyc cphyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM! I'd be happy once we fix future incompatibilities with Cython 3.1 though :)

@neutrinoceros
Copy link
Member Author

it might actually be a no-op, depending on how cython/cython#4310 turns out

@neutrinoceros neutrinoceros merged commit 14c49c4 into yt-project:main Oct 10, 2023
@neutrinoceros neutrinoceros deleted the require_cython_3.0.3 branch October 10, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cphyc cphyc cphyc approved these changes

@chrishavlin chrishavlin chrishavlin left review comments

Assignees
No one assigned
Labels
bug build related to the build process dependencies Pull requests that update a dependency file tests: running tests Issues with the test setup
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

BLD: (yt 4.3) cp312 wheels require Cython 3.0.3
3 participants
@neutrinoceros @cphyc @chrishavlin