MNT: fix auto-reports for bleeding edge CI #4728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
fix_auto_report
branch
from
4d784f0 to
8a39873
Compare
|
So it turns out testing this properly is a more involved process than I thought because of how GitHub actions and authentification integrate with each other. In short, GitHub actions runners authenticate as their own user, not as the account owning a pull request and if the branch is originated from a fork, they only get read permissions to the main repo (which makes sense). This means I needed to test this on my fork instead of here (or to create the branch on the main repo). |
neutrinoceros
added
bug
tests: running tests
|
@yt-fido test this please |
chrishavlin
approved these changes
Nov 6, 2023
|
Let's merge this to give tonight's run a chance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: fix #4721
I suspect that the
labelsparameter is malformed (this is the only one I'm using that's not used in the matplotlib model workflow, and it's not well documented)I'm going to test this by removing the conditional trigger.