Support for cosmic ray fields in GAMER #4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @ChunYen-Chen |
|
@yt-fido test this please |
1 similar comment
|
@yt-fido test this please |
|
This is ready to go now--thanks @Xarthisius |
…he correct options are turned on
matthewturk
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
GAMER recently included support for cosmic ray fluids. This PR supports these fields by adding a
gamma_crattribute to the GAMERDatasetif it is found in the runtime parameters, adds the fields("gas", "cosmic_ray_energy_density")and("gas", "cosmic_ray_pressure"), and modifies the computation of the non-cosmic ray gas thermal energy, pressure, and temperature to account for the existence of the cosmic ray energy if it is available.Will add a test, but I tried this out on the cosmic ray shock tube problem in GAMER and it seems to work.
PR Checklist