Backport PR #4859: BLD: add support for numpy 2 #4870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
dependencies
|
The failures seem real; do you have any idea what's happening? |
|
It's unrelated. It's been happening on every backport PR since GAMER dataset in store were updated somehow. Since it didn't happen in a PR I'm having trouble finding the exact conversation that mentioned it, but @jzuhone confirmed that it was unfixable. If I recall correctly it was done in support of #4739 |
cphyc
approved these changes
Apr 5, 2024
chrishavlin
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manual backport to workaround a small conflict (numpy was pinned to <2 on the backport branch but not on main)