Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace passport-openidconnect with something better #3

Open
leeomara opened this issue Nov 21, 2020 · 3 comments
Open

Replace passport-openidconnect with something better #3

leeomara opened this issue Nov 21, 2020 · 3 comments

Comments

@leeomara
Copy link
Member

leeomara commented Nov 21, 2020

passport-openidconnect, at version 0.0.2, hasn't been updated in years and is responsible (I think) for some of the security alerts identified by Dependabot (https://github.com/ytgov/vue-template/network/alerts).

One option is openid-client, a certified Open ID Connect client for Relying Parties that supports passport.

@leeomara leeomara changed the title Replace passport-openidconnect with openid-client Replace passport-openidconnect with something better Aug 20, 2021
@leeomara
Copy link
Member Author

Max has done work implementing a new library. See 2d23236.

@ryanjagar
Copy link
Contributor

ryanjagar commented Oct 22, 2021

I've replaced passport-openidconnect with express-openid connect and cleaned out all the package files for /api. As expected, removing the old library cleaned up a lot of the more egregious security errors.

Todo:

  • Update README to reflect new ENV settings
  • Update env.sampe to reflect new ENV settings

@leeomara
Copy link
Member Author

This work appears to have been done mostly in 480273, 65b15d5.

In the future, I think it would be preferable if this work was done in a branch and a pull request was created to track this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants