fix code scanning

yukani · Aug 15, 2023 · 9e95885 · 9e95885
1 parent d4f4c04
commit 9e95885
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/source/game_sa/Audio/AEAudioUtility.cpp b/source/game_sa/Audio/AEAudioUtility.cpp
@@ -112,7 +112,7 @@ bool CAEAudioUtility::GetBankAndSoundFromScriptSlotAudioEvent(int32& slot, int32
         return false;
 
     if (slot < 2000) {
-        outBank = gScriptBanksLookup[slot];
+        outBank = gScriptBanksLookup[slot - 1800];
         return true;
     }
 

diff --git a/source/game_sa/Audio/hardware/AEAudioHardware.cpp b/source/game_sa/Audio/hardware/AEAudioHardware.cpp
@@ -85,7 +85,7 @@ bool CAEAudioHardware::Initialise() {
         return false;
     }
 
-    CoInitialize(nullptr);
+    VERIFY(SUCCEEDED(CoInitialize(nullptr)));
 
     // TODO: We need EAX headers here.
     //

diff --git a/source/game_sa/Audio/managers/AEAmbienceTrackManager.cpp b/source/game_sa/Audio/managers/AEAmbienceTrackManager.cpp
@@ -16,7 +16,7 @@ void CAEAmbienceTrackManager::InjectHooks() {
     RH_ScopedInstall(IsAmbienceRadioActive, 0x4D6D40);
     RH_ScopedInstall(PlaySpecialMissionAmbienceTrack, 0x4D6D50);
     RH_ScopedInstall(StopSpecialMissionAmbienceTrack, 0x4D6D60);
-    RH_ScopedInstall(UpdateAmbienceTrackAndVolume, 0x4D6E60, { .reversed = false });
+    RH_ScopedInstall(UpdateAmbienceTrackAndVolume, 0x4D6E60, { .reversed = true });
     RH_ScopedInstall(Service, 0x4D76C0);
 }
 
@@ -231,6 +231,7 @@ void CAEAmbienceTrackManager::UpdateAmbienceTrackAndVolume() {
             break;
         case 62:
             m_AmbienceRadioStation = RADIO_TALK;
+            break;
         case 64:
             specialTrackId = 151;
             break;

diff --git a/source/game_sa/Scripts/Commands/Player.cpp b/source/game_sa/Scripts/Commands/Player.cpp
@@ -196,7 +196,6 @@ void notsa::script::commands::player::RegisterHandlers() {
     REGISTER_COMMAND_UNIMPLEMENTED(COMMAND_SET_GANG_PLAYER_ATTITUDE);
     REGISTER_COMMAND_UNIMPLEMENTED(COMMAND_IS_PLAYER_IN_REMOTE_MODE);
     REGISTER_COMMAND_UNIMPLEMENTED(COMMAND_SET_ANIM_GROUP_FOR_PLAYER);
-    REGISTER_COMMAND_UNIMPLEMENTED(COMMAND_RESET_NUM_OF_MODELS_KILLED_BY_PLAYER);
     REGISTER_COMMAND_UNIMPLEMENTED(COMMAND_GET_NUM_OF_MODELS_KILLED_BY_PLAYER);
     REGISTER_COMMAND_UNIMPLEMENTED(COMMAND_SET_CAR_ONLY_DAMAGED_BY_PLAYER);
     //REGISTER_COMMAND_UNIMPLEMENTED(COMMAND_SET_PLAYER_NEVER_GETS_TIRED);