Skip to content

Commit

Permalink
acpi_gpiobus: Narrow scope of NOT_YET
Browse files Browse the repository at this point in the history
GPIO interrupts work just fine and will be used shortly.  We still
do not support GPIO_INTR_SHAREABLE however, so leave that within
the NOT_YET scope.

Reviwed by:	andrew
MFC after:	1 week
Sponsored by:	Amazon
Differential Revision:	https://reviews.freebsd.org/D47251
  • Loading branch information
cperciva committed Oct 26, 2024
1 parent bc0d10d commit 2d42199
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions sys/dev/gpio/acpi_gpiobus.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ acpi_gpiobus_convflags(ACPI_RESOURCE_GPIO *gpio_res)
uint32_t flags = 0;

/* Figure out pin flags */
#ifdef NOT_YET
/* These are currently unused. */
if (gpio_res->ConnectionType == ACPI_RESOURCE_GPIO_TYPE_INT) {
switch (gpio_res->Polarity) {
case ACPI_ACTIVE_HIGH:
Expand All @@ -69,10 +67,12 @@ acpi_gpiobus_convflags(ACPI_RESOURCE_GPIO *gpio_res)
break;
}

#ifdef NOT_YET
/* This is not currently implemented. */
if (gpio_res->Shareable == ACPI_SHARED)
flags |= GPIO_INTR_SHAREABLE;
}
#endif
}
switch (gpio_res->IoRestriction) {
case ACPI_IO_RESTRICT_INPUT:
flags |= GPIO_PIN_INPUT;
Expand Down

0 comments on commit 2d42199

Please sign in to comment.