Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: 在.nfo中为UGC视频添加作者、标签、分区字段 #132
✨ feat: 在.nfo中为UGC视频添加作者、标签、分区字段 #132
Changes from 4 commits
2a5c018
b8ea250
9736331
87da904
c74e366
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请问
genre
是什么的缩写呢?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看到 commit message 里的描述了 genre 是分区是嘛?好奇怪的缩写 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有一说一我也觉得奇怪,在emby刮削的时候,genre被认为是「流派」...而且我自己把ugc内容当做movie来处理的,确实genre能识别;
于是使用genre对应分区名字;
如果有更好的选择,我觉得也可以改掉,目前这个nfo我还没有在emby和infuse上测试,尚不清楚genre能不能工作
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里也在 cheese 和 bangumi 里补充一下吧,直接
UNKNOWN
即可,另外文档(README.md
)里的「存放子路径模板」需要加一下这一个字段,并在表格里说明下什么情况会有这个字段~There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
稍晚一些,可能要等几天,我先测试emby的nfo,一起调整
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metadata 新增了字段,Bangumi 和 Cheese 是否可以对齐一下呢?可以先空着,记个 TODO 即可
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
担心Bangumi和Cheese和UGC的MetaData格式不同,我觉得可以先不加,不加有影响吗?如果不加会导致bangumi报错的话,那就加个可好了...实际上MetaData应该区分UGCMetaData, BangumiMetaData吧?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不加会影响类型提示吧,Linter(pyright)应该会过不了
Metadata 这块因为我没有深度使用过细节上不太清楚,不过确实是可以这样子的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
本地没lint到...ok,刚刚看了下,我准备加上这几个
actor
genre
tag
website