Pubovl (including extras) #905

Conticop · 2020-08-03T15:56:07Z

Fixes #807
Original author: dd

I took some time to get Pubovl compatible with the latest master, and it has arrived here now.
I have tested it ingame, all works fine.
(See the above forum post for more info about Pubovl and its features.)

The bigger issue for me is that it makes it much easier to write a wallhack. All you need to do is delete the "only allow wallhack if you are spectator" check.

I thought, well it was made available to the public since a long time ago, with binaries precompiled and available for download from the same forum post above. So what the heck.
There'll always be cheaters in such game(s). Merge this to make admins' lives easier.

Original author: dd

Let's not do this.

Conticop · 2020-08-03T17:02:05Z

I suppose I should have removed the comments...
(I just noticed some spacing got messed up too.)

* Removed useless comments. Rewritten a couple. * Modernized some code fragments. * Fixed indentation stuff (hopefully).

Conticop · 2020-08-03T19:52:06Z

There, this is ready for review.
cc @yvt

Sources/Draw/GLOptimizedVoxelModel.cpp

Resources/Shaders/BasicBlockOutlines.program

siecvi · 2020-08-05T02:04:04Z

The extras should be removed or tweaked (cg_outlines, cg_textures), as they give some visibility advantage.
The player model already have neon-like colors, but when raising texture strength to more than 20 it gives extra contrast, that and cartoon-like outlines would give the perfect visibility.

* Removed `cg_multiTextureStrength` (unused). * Decreased `cg_textureStrength` by half. * Adjusted min/max of `cg_outlineStrength`.

Haxk20 · 2021-05-04T15:48:04Z

@Conticop Could you get this updated with the latest master changes ?
@yvt A little ping
This is an absolutely amazing change. While yes cheaters could easily enable ESP in real game.
Tho i would argue that it is FAR far easier for a cheater to download already made hacks then poking in the code.
And it is not that hard to add some multiple layers of checks in the code if they wanted to make ESP accesible to real gameplay.

JimPix1 · 2022-08-11T11:08:56Z

@yvt Ping

yvt

Sorry for the delay. Although it's marked as draft now, I'm going to submit a review anyway to explain why it cannot be merged in the current state:

The largest problem is already stated by @siecvi: In addition to fixing #807, the PR introduces multiple features irrelevant to the primary change, such as the outline (NotTodo 2-3) and texturing effects and even global sound volume control. The PR must be kept minimal and focus on a single logical change.

Another problem concerns code quality - bypassing abstraction, the use of global variables, and such. The existing code is bad as it is, but let's not make it even worse.

yvt · 2020-08-04T05:26:28Z

Resources/Scripts/Gui/Client/ChatSayWindow.as

@@ -190,6 +190,7 @@ namespace spades {
                @field = CommandField(Manager, ui.chatHistory);
                field.Bounds = AABB2(winX, winY, winW, 30.f);
                field.Placeholder = _Tr("Client", "Chat Text");
+                field.MaxLength = 93;


Irrelevant to the primary change.

yvt · 2020-08-04T05:32:52Z

Resources/Scripts/Gui/Preferences.as

+            layouter.AddHeading(_Tr("Preferences", "OpenGL Effects"));
+            layouter.AddToggleField(_Tr("Preferences", "Outlines"), "cg_outlines");
+            layouter.AddSliderField(_Tr("Preferences", "Outline Strength"), "cg_outlineStrength", 2, 5, 1,
+                                    ConfigNumberFormatter(0, "px"));
+            layouter.AddToggleField(_Tr("Preferences", "Textures"), "cg_textures");
+            layouter.AddToggleField(_Tr("Preferences", "Multi-Texture Mode"), "cg_multiTextures");
+            layouter.AddSliderField(_Tr("Preferences", "Texture Strength"), "cg_textureStrength", 0, 100, 1,
+                                    ConfigNumberFormatter(0, "%"));


The outline (NotTodo 2-3) and texturing effects are clearly out of scope of this PR and should be removed.

yvt · 2020-08-04T05:34:23Z

Sources/Client/Client.cpp

 namespace spades {
 	namespace client {

+		Client *Client::globalInstance = nullptr;


Don't store Client * in a global variable.

yvt · 2020-08-04T05:35:38Z

Sources/Client/Client.h

@@ -479,6 +481,10 @@ namespace spades {
 			void LocalPlayerCreatedLineBlock(IntVector3, IntVector3) override;
 			void LocalPlayerHurt(HurtType type, bool sourceGiven, Vector3 source) override;
 			void LocalPlayerBuildError(BuildFailureReason reason) override;
+
+			static bool AreCheatsEnabled(); // 'cheats', i.e. spectator wallhack or player names


The name needs to be more descriptive. How is this different from WallhackActive?

Don't make this member function static

yvt · 2020-08-04T05:35:59Z

Sources/Client/Client.h

@@ -479,6 +481,10 @@ namespace spades {
 			void LocalPlayerCreatedLineBlock(IntVector3, IntVector3) override;
 			void LocalPlayerHurt(HurtType type, bool sourceGiven, Vector3 source) override;
 			void LocalPlayerBuildError(BuildFailureReason reason) override;
+
+			static bool AreCheatsEnabled(); // 'cheats', i.e. spectator wallhack or player names
+			static bool WallhackActive();


Rename this to IsWallhackActive

Don't make this member function static

yvt · 2022-08-13T09:17:13Z

Sources/Audio/ALDevice.cpp

+					// Update master volume control
+					if (s_volume_previous != (int)s_volume) {
+						// update the previous volume
+						s_volume_previous = (int)s_volume;
+						// compute the new dB level, where 27.71373379 ~ 10^(1/log(2)), and update
+						// the master gain to it
+						if ((int)s_volume == 0) {
+							dBPrevious = 0;
+						} else {
+							dBPrevious = powf(27.71373379f, log(((float)s_volume) / 100.0f));
+						}
+						al::qalListenerf(AL_GAIN, dBPrevious);
+					}
+


Irrelevant to the primary change.

yvt · 2022-08-13T09:17:19Z

Sources/Audio/ALDevice.cpp

+SPADES_SETTING(s_volume);
+extern int s_volume_previous = 100; // keep track of the "previous" volume so the dB isn't recomputed when unnecessary
+extern float dBPrevious = 1.0f;
+


Irrelevant to the primary change.

yvt · 2022-08-13T09:17:27Z

Sources/Audio/YsrDevice.cpp

+SPADES_SETTING(s_volume);
+extern int s_volume_previous;
+extern float dBPrevious;
+


Irrelevant to the primary change.

yvt · 2022-08-13T09:17:32Z

Sources/Audio/YsrDevice.cpp

+
+			// Update master volume control
+			if (s_volume_previous != (int)s_volume) {
+				// update the previous volume
+				s_volume_previous = (int)s_volume;
+				// compute the new dB level, where 27.71373379 ~ 10^(1/log(2)), and update the
+				// master gain to it
+				if ((int)s_volume == 0) {
+					dBPrevious = 0;
+				} else {
+					dBPrevious = powf(27.71373379f, log(((float)s_volume) / 100.0f));
+				}
+			}
+			param.volume = dBPrevious;
+


Irrelevant to the primary change.

yvt · 2022-08-13T15:20:38Z

Sources/Draw/GLRenderer.cpp

-			{
+			bool visiblePlayers[32];
+
+			if (!client::Client::WallhackActive()) {
 				GLProfiler::Context p(*profiler, "Non-mirrored Objects");
-				RenderObjects();
+				RenderObjects(false);


Don't refer to Client directly from the renderer layer. Introduce adequate abstractions in the renderer API.

JimPix1 · 2022-08-13T15:30:25Z

Thanks for taking the time to reply, yvt. Hoping these problems get fixed 🤞

Conticop added 2 commits August 3, 2020 17:24

Fixes yvt#807

10cdecd

Original author: dd

...

2e8f7b2

Let's not do this.

Fixing stuff right offpress.

34143d3

* Removed useless comments. Rewritten a couple. * Modernized some code fragments. * Fixed indentation stuff (hopefully).

Conticop commented Aug 4, 2020

View reviewed changes

Sources/Draw/GLOptimizedVoxelModel.cpp Outdated Show resolved Hide resolved

feikname added the PR: new-feature label Aug 4, 2020

feikname reviewed Aug 4, 2020

View reviewed changes

Resources/Shaders/BasicBlockOutlines.program Outdated Show resolved Hide resolved

Conticop added 3 commits August 5, 2020 12:45

Add a missing newline at the EOF.

8689e83

Remove weird indentation.

85ea6b5

Twerking stuff.

eff833f

* Removed `cg_multiTextureStrength` (unused). * Decreased `cg_textureStrength` by half. * Adjusted min/max of `cg_outlineStrength`.

Conticop marked this pull request as draft August 6, 2020 17:02

yvt requested changes Aug 13, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pubovl (including extras) #905

Pubovl (including extras) #905

Conticop commented Aug 3, 2020

Conticop commented Aug 3, 2020 •

edited

Loading

Conticop commented Aug 3, 2020

siecvi commented Aug 5, 2020 •

edited

Loading

Haxk20 commented May 4, 2021

JimPix1 commented Aug 11, 2022

yvt left a comment •

edited

Loading

yvt Aug 4, 2020 •

edited

Loading

yvt Aug 4, 2020

yvt Aug 4, 2020

yvt Aug 4, 2020

yvt Aug 4, 2020

yvt Aug 13, 2022 •

edited

Loading

yvt Aug 13, 2022 •

edited

Loading

yvt Aug 13, 2022 •

edited

Loading

yvt Aug 13, 2022 •

edited

Loading

yvt Aug 13, 2022

JimPix1 commented Aug 13, 2022

Pubovl (including extras) #905

Are you sure you want to change the base?

Pubovl (including extras) #905

Conversation

Conticop commented Aug 3, 2020

Conticop commented Aug 3, 2020 • edited Loading

Conticop commented Aug 3, 2020

siecvi commented Aug 5, 2020 • edited Loading

Haxk20 commented May 4, 2021

JimPix1 commented Aug 11, 2022

yvt left a comment • edited Loading

Choose a reason for hiding this comment

yvt Aug 4, 2020 • edited Loading

Choose a reason for hiding this comment

yvt Aug 4, 2020

Choose a reason for hiding this comment

yvt Aug 4, 2020

Choose a reason for hiding this comment

yvt Aug 4, 2020

Choose a reason for hiding this comment

yvt Aug 4, 2020

Choose a reason for hiding this comment

yvt Aug 13, 2022 • edited Loading

Choose a reason for hiding this comment

yvt Aug 13, 2022 • edited Loading

Choose a reason for hiding this comment

yvt Aug 13, 2022 • edited Loading

Choose a reason for hiding this comment

yvt Aug 13, 2022 • edited Loading

Choose a reason for hiding this comment

yvt Aug 13, 2022

Choose a reason for hiding this comment

JimPix1 commented Aug 13, 2022

Conticop commented Aug 3, 2020 •

edited

Loading

siecvi commented Aug 5, 2020 •

edited

Loading

yvt left a comment •

edited

Loading

yvt Aug 4, 2020 •

edited

Loading

yvt Aug 13, 2022 •

edited

Loading

yvt Aug 13, 2022 •

edited

Loading

yvt Aug 13, 2022 •

edited

Loading

yvt Aug 13, 2022 •

edited

Loading