Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more types to improve code readability #111

Merged
merged 8 commits into from
Oct 5, 2023

Conversation

syou6162
Copy link
Contributor

@syou6162 syou6162 commented Sep 30, 2023

The following types have been added to improve code readability

  • Add type for catalog with CatalogArtifact
    • The current type definition is Optional[dict], but it is difficult to know what kind of key it has, so we changed it to clearly show CatalogArtifact.
  • Replace Tuple[str, str, str] with CatalogKey.
    • It is hard to remember what is the first in a code like parts[-1], so changed it to be easier to understand with CatalogKey.

@syou6162 syou6162 changed the title Add more types Add more types to improve code readability Sep 30, 2023
@syou6162 syou6162 marked this pull request as ready for review September 30, 2023 17:53
@syou6162 syou6162 marked this pull request as draft September 30, 2023 18:35
@syou6162 syou6162 marked this pull request as ready for review September 30, 2023 18:52
@z3z1ma
Copy link
Owner

z3z1ma commented Oct 5, 2023

LGTM much better

@z3z1ma z3z1ma merged commit fe0679b into z3z1ma:main Oct 5, 2023
2 checks passed
@syou6162 syou6162 deleted the add_more_types branch October 5, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants