Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant set load balancer scheme on deployment #351

Open
sean-mcgimpsey opened this issue Apr 29, 2020 · 1 comment
Open

Cant set load balancer scheme on deployment #351

sean-mcgimpsey opened this issue Apr 29, 2020 · 1 comment

Comments

@sean-mcgimpsey
Copy link

sean-mcgimpsey commented Apr 29, 2020

Were unable to set the load balancer scheme (internal / internet-facing) on the ingress-controller deployment.
We'd ideally like to have two deployments of this controller (1 - internal, 1 - internet-facing).

Looking at the documentation, i would have thought passing the arg --scheme=internal to the controller deployment would work, however it is not recognised as an argument. For example;

-----
        args:
          - "--ip-addr-type=dualstack"
          - "--scheme=internal"
          - "--health-check-port=32080" # Using nginx ingress
          - "--health-check-path=/healthz"
          - "--target-port=32080" # Using nginx ingress
-----

I've had a look at controller.go, and it looks as though it isn't possible to define the scheme at the deployment level - only ingress, with annotations.

It would be really good to be able to define this at the deployment level.

@mikkeloscar
Copy link
Collaborator

mikkeloscar commented Apr 29, 2020

Seems like a reasonable feature. PRs are ofc. welcome, otherwise I may try to take a look at it in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants