Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scalyr: Use parse_lines_as_json for docker containers #49

Open
mohabusama opened this issue Oct 4, 2017 · 3 comments
Open

Scalyr: Use parse_lines_as_json for docker containers #49

mohabusama opened this issue Oct 4, 2017 · 3 comments
Labels
enhancement in progress

Comments

@mohabusama
Copy link
Contributor

As described here: https://github.com/scalyr/scalyr-agent-2/releases/tag/v2.0.29

Also suggested here: zalando-incubator/kubernetes-on-aws#620
@mohabusama mohabusama mentioned this issue Oct 4, 2017
Closed
@eicnix
Copy link
Contributor

eicnix commented Jul 9, 2018

Hi @mohabusama,

I would also like to tackle this issue.

@mohabusama
Copy link
Contributor Author

Hi @eicnix ,, yep sure, please go ahead 😄

My only remark would be to make it configurable (WATCHER_SCALYR_PARSE_LINE_JSON).

I haven't really looked on how this works, but my main concern would be to make sure we do not break existing manifests which set a specific parser expecting the normal JSON message. If Scalyr agent will just add extra attributes and do not modify the message (which parsers depend on), then migration would be easier.

eicnix added a commit to eicnix/kubernetes-log-watcher that referenced this issue Jul 10, 2018
@eicnix
Adds configurable JSON log parsing(zalando-incubator#49)
61fcf18 
With the new configuration parameter `WATCHER_SCALYR_PARSE_LINES_JSON` the Scalyr agent can be configured to parse log lines as JSON entries which is useful to process raw Docker logs. This behaviour is disabled by default.
eicnix added a commit to eicnix/kubernetes-log-watcher that referenced this issue Jul 11, 2018
@eicnix
Adds configurable JSON log parsing(zalando-incubator#49)
7ea637c 
With the new configuration parameter `WATCHER_SCALYR_PARSE_LINES_JSON` the Scalyr agent can be configured to parse log lines as JSON entries which is useful to process raw Docker logs. This behaviour is disabled by default.
mohabusama pushed a commit that referenced this issue Jul 11, 2018
@eicnix @mohabusama
Adds configurable JSON log parsing(#49) (#66)
5e1e18f 
With the new configuration parameter `WATCHER_SCALYR_PARSE_LINES_JSON` the Scalyr agent can be configured to parse log lines as JSON entries which is useful to process raw Docker logs. This behaviour is disabled by default.
@mohabusama
Copy link
Contributor Author

@eicnix I didn't have much time to properly test this change. Could you try with this image:

registry.opensource.zalan.do/eagleeye/kubernetes-log-watcher:0.20-2-g5e1e18f

@mohabusama mohabusama mentioned this issue Jul 24, 2018
Merged
@femueller femueller mentioned this issue Oct 5, 2018
Merged
femueller pushed a commit that referenced this issue Oct 15, 2018
@eicnix
Adds configurable JSON log parsing(#49) (#66)
03b5bd3 
With the new configuration parameter `WATCHER_SCALYR_PARSE_LINES_JSON` the Scalyr agent can be configured to parse log lines as JSON entries which is useful to process raw Docker logs. This behaviour is disabled by default.
femueller pushed a commit that referenced this issue Oct 15, 2018
Revert "Adds configurable JSON log parsing(#49) (#66)"
eed4ca4 
This reverts commit 5e1e18f.
femueller pushed a commit that referenced this issue Oct 16, 2018
Revert "Adds configurable JSON log parsing(#49) (#66)"
1ae8173 
This reverts commit 5e1e18f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mohabusama @eicnix