Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: endpointslices serving should be ignored #2708

Closed
wants to merge 6 commits into from
Closed

Fix: endpointslices serving should be ignored #2708

wants to merge 6 commits into from

Conversation

szuecs
Copy link
Member

@szuecs szuecs commented Oct 31, 2023

fix #2684

AlexanderYastrebov and others added 6 commits October 17, 2023 19:05
@AlexanderYastrebov @szuecs
filters/scheduler: handle errors (#2680)
1f45d7c 
Make lifo, lifoGroup and fifo filters backed error aware and remove
cleanup from the proxy.

Follow up on #1054, #1086 and #2239
Updates #1238

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@AlexanderYastrebov
filters/scheduler: refactor fifo tests (#2693)
c7c8a9c 
* separate argument tests from behaviour test
* use eskip to define filter configuration
* use TestFifo prefix for all test names

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@szuecs
feature: filter fifoWithBody (#2685)
7f45e4e 
* feature: filter fifoWithBody that works similar to fifo(), but release deferred until body streaming to client was finished
* fix: fifo() and fifoWithBody() with canceled requests

Both filters did not check for canceled context from request before semaphore.Acquire, see golang/go#63615

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
@MustafaSaber
Prevent multiple items per yaml item (#2691)
e7e22ed 
* Don't allow more than one filter/predicate per yaml/json item

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
@MustafaSaber
Use %q instead of %s for strings with quotes (#2700)
c8561da 
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
@szuecs
fix: endpointslices should not consider Serving condition
bd4987a 
see also #2684

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
@szuecs szuecs closed this Oct 31, 2023
@szuecs szuecs deleted the fix/epslices-serving-should-be-ignored branch October 31, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

endpointslices Serving vs Ready condition possible bug
3 participants
@szuecs @AlexanderYastrebov @MustafaSaber