-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis Swarm Configuration documented #2744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Troy Kohler <troy.kohler@zalando.de>
@trkohler if you create an image it's of course great for the reader. Maybe also tell something about the routesrv case, because if you have a non-kubernetes skipper data-plane and use routesrv, you need to set these options to routesrv and set |
Signed-off-by: Troy Kohler <troy.kohler@zalando.de>
👍 |
Signed-off-by: Troy Kohler <troy.kohler@zalando.de>
👍 |
1 similar comment
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should resolve: #2043
my notes & understanding on how it works based on what I read https://github.com/zalando/skipper/pull/2009/files
kubernetes-redis-service-namespace
- sets namespace for redis to be used to lookup endpointskubernetes-redis-service-name
- sets name for redis to be used to lookup endpoints. The only required parameter to redis swarm to be working.kubernetes-redis-service-port
- sets port for redis to be used to lookup endpoints, default value is 6379skipper is getting all endpoints using kubernetes service for redis cluster
then it updates the list of those addresses each 10 seconds
updates works in background with the separate goroutine
this enables autodiscovery for new redis instances
question: do we need an image / system design of how auto-discovery works? for me it looks like it's simple to understand, but I'm open for suggestions.