Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Swarm Configuration documented #2744

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Conversation

trkohler
Copy link
Member

@trkohler trkohler commented Nov 20, 2023

should resolve: #2043

my notes & understanding on how it works based on what I read https://github.com/zalando/skipper/pull/2009/files

kubernetes-redis-service-namespace - sets namespace for redis to be used to lookup endpoints
kubernetes-redis-service-name - sets name for redis to be used to lookup endpoints. The only required parameter to redis swarm to be working.
kubernetes-redis-service-port - sets port for redis to be used to lookup endpoints, default value is 6379

skipper is getting all endpoints using kubernetes service for redis cluster
then it updates the list of those addresses each 10 seconds
updates works in background with the separate goroutine
this enables autodiscovery for new redis instances

question: do we need an image / system design of how auto-discovery works? for me it looks like it's simple to understand, but I'm open for suggestions.

Signed-off-by: Troy Kohler <troy.kohler@zalando.de>
@trkohler trkohler marked this pull request as ready for review November 20, 2023 07:30
@szuecs
Copy link
Member

szuecs commented Nov 21, 2023

@trkohler if you create an image it's of course great for the reader.

Maybe also tell something about the routesrv case, because if you have a non-kubernetes skipper data-plane and use routesrv, you need to set these options to routesrv and set -swarm-redis-remote to the skipper data-plane to fetch the redis endpoints from routesrv API.

Signed-off-by: Troy Kohler <troy.kohler@zalando.de>
@szuecs
Copy link
Member

szuecs commented Nov 27, 2023

👍

Signed-off-by: Troy Kohler <troy.kohler@zalando.de>
@AlexanderYastrebov
Copy link
Member

👍

1 similar comment
@MustafaSaber
Copy link
Member

👍

@MustafaSaber MustafaSaber merged commit 2fd26a2 into zalando:master Nov 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document redis autoscaling
4 participants