initial commit for enhancing fuzz tests #2745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sepehrdaddev
force-pushed
the
enhance-fuzz-tests
branch
from
bb35d0e to
96a64d3
Compare
Signed-off-by: Sepehrdad Sh <26747519+sepehrdaddev@users.noreply.github.com>
sepehrdaddev
force-pushed
the
enhance-fuzz-tests
branch
from
96a64d3 to
a8f05b9
Compare
szuecs
reviewed
Nov 21, 2023
fuzz/fuzz_targets/FuzzServer.go
Outdated
| initialized = true | ||
| } | ||
|
|
||
| conn, err := net.Dial("tcp", "localhost:9090") |
There was a problem hiding this comment.
you might want to loop and test if you can Dial before, because there is no guarantee that skipper.Run was already executed.
There was a problem hiding this comment.
I have added a retry mechanism as per your suggestion.
…erver Signed-off-by: Sepehrdad Sh <26747519+sepehrdaddev@users.noreply.github.com>
Signed-off-by: Sepehrdad Sh <26747519+sepehrdaddev@users.noreply.github.com>
szuecs
reviewed
Nov 21, 2023
| } | ||
|
|
||
| conn, err := connect("localhost:9090") | ||
| conn, err := connect(address) |
There was a problem hiding this comment.
you need to do something like:
var (
err error
conn *tcp.Conn // out of my head so maybe other type
)
for i:=0; i<10; i++ {
conn, err = connect(address)
if err != nil {
time.Sleep(100*time.Millisecond)
continue
}
break
}
Signed-off-by: Sepehrdad Sh <26747519+sepehrdaddev@users.noreply.github.com>
sepehrdaddev
force-pushed
the
enhance-fuzz-tests
branch
from
38e311e to
fe32254
Compare
Signed-off-by: Sepehrdad Sh <26747519+sepehrdaddev@users.noreply.github.com>
…s using func init will affect other fuzz targets. Signed-off-by: Sepehrdad Sh <26747519+sepehrdaddev@users.noreply.github.com>
…rom oss-fuzz. Signed-off-by: Sepehrdad Sh <26747519+sepehrdaddev@users.noreply.github.com>
… option to compile without sanitizers. Signed-off-by: Sepehrdad Sh <26747519+sepehrdaddev@users.noreply.github.com>
|
👍 |
1 similar comment
|
👍 |
|
@szuecs I will create follow up PRs to add these fuzz targets to oss-fuzz and then another one to remove the old ones from |
This was referenced Nov 28, 2023
DavidKorczynski
pushed a commit
to google/oss-fuzz
that referenced
this pull request
Nov 29, 2023
…11278) adds more fuzz targets and also dictionaries to improve the coverage. continuation of zalando/skipper#2745 Signed-off-by: Sepehrdad Sh <26747519+sepehrdaddev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds multiple fuzz targets with new directory structure and makefile.
libfuzzer and sanitizer options mirror oss-fuzz.