Merge CW2023 changes #2751
Closed
Merge CW2023 changes #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* separate argument tests from behaviour test * use eskip to define filter configuration * use TestFifo prefix for all test names Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
* feature: filter fifoWithBody that works similar to fifo(), but release deferred until body streaming to client was finished * fix: fifo() and fifoWithBody() with canceled requests Both filters did not check for canceled context from request before semaphore.Acquire, see golang/go#63615 Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
* Don't allow more than one filter/predicate per yaml/json item Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
see also #2684 Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
feature: routesrv enable profiling feature: routesrv split supportListener for metrics and profiling from the main listener feature: routesrv shutdown supportServer gracefully test: routesrv shutdown main listener and supportListener test: add more routesrv coverage to reach close to 80% doc: add routesrv metrics and profiling docs Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
* feature: set Tag "skipper.route_id" to `route.Id` in all ingress spans including shunt and loopback routes Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Validate that network backends doesn't have paths Include query params into validation Include missing scheme, rename functions for consistant naming and ensure we only validate network backends. Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Add a filter to set request header value from secret with optional
prefix and suffix.
It is similar to `bearerinjector` which is equivalent to
`setRequestHeaderFromSecret("Authorization", "/tokens/my-token", "Bearer ")`
For #1952
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Support gzip encoding to reduce response size. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
…ation header (#2747) Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Closed
szuecs
reviewed
Nov 27, 2023
| # HELP routesrv_backend_combined_duration_seconds Duration in seconds of a proxy backend combined. | ||
| # TYPE routesrv_backend_combined_duration_seconds histogram | ||
| routesrv_backend_combined_duration_seconds_bucket{version="v0.18.38-8",le="0.005"} 5 | ||
| routesrv_backend_combined_duration_seconds_bucket{version="v0.18.38",le="0.01"} 5 |
There was a problem hiding this comment.
The version label would not be there if you drop the linking change.
We would need to tell how to create the version label @AlexanderYastrebov by prometheus relabel config
There was a problem hiding this comment.
We need to drop version label from the docs
There was a problem hiding this comment.
I think we'd need a proper PR that reverts 37a76cd and updates docs
There was a problem hiding this comment.
Created #2752 to address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not squash.
This branch is created by re-basing cw2023freeze over master and dropping 37a76cd in favor of zalando-incubator/kubernetes-on-aws#6579