Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cw2023freeze #2754

Merged
merged 15 commits into from
Nov 28, 2023
Merged

Cw2023freeze #2754

merged 15 commits into from
Nov 28, 2023

Conversation

szuecs
Copy link
Member

@szuecs szuecs commented Nov 27, 2023

merge back
Do not squash

AlexanderYastrebov and others added 15 commits November 27, 2023 13:18
Make lifo, lifoGroup and fifo filters backed error aware and remove
cleanup from the proxy.

Follow up on #1054, #1086 and #2239
Updates #1238

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
* separate argument tests from behaviour test
* use eskip to define filter configuration
* use TestFifo prefix for all test names

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
* feature: filter fifoWithBody that works similar to fifo(), but release deferred until body streaming to client was finished
* fix: fifo() and fifoWithBody() with canceled requests

Both filters did not check for canceled context from request before semaphore.Acquire, see golang/go#63615

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
* Don't allow more than one filter/predicate per yaml/json item

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
* feature: add "version" label to all prometheus metrics

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>

* fix: prometheus label definitions and label use
test: add version label

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
see also #2684

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
feature: routesrv enable profiling
feature: routesrv split supportListener for metrics and profiling from the main listener
feature: routesrv shutdown supportServer gracefully
test: routesrv shutdown main listener and supportListener
test: add more routesrv coverage to reach close to 80%
doc: add routesrv metrics and profiling docs

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
* feature: set Tag "skipper.route_id" to `route.Id` in all ingress spans including shunt and loopback routes

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Validate that network backends doesn't have paths

Include query params into validation

Include missing scheme, rename functions for consistant naming and ensure we only validate network backends.

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Add a filter to set request header value from secret with optional
prefix and suffix.

It is similar to `bearerinjector` which is equivalent to
`setRequestHeaderFromSecret("Authorization", "/tokens/my-token", "Bearer ")`

For #1952

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Support gzip encoding to reduce response size.

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
…ation header (#2747)

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
* Revert "feature: add "version" label to all prometheus metrics (#2706)"

This reverts commit b9dc460.

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>

* docs/operation: remove version metrics label

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>

---------

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@AlexanderYastrebov
Copy link
Member

I've manually set DCO check to pass.

@AlexanderYastrebov
Copy link
Member

👍

2 similar comments
@RomanZavodskikh
Copy link
Contributor

👍

@szuecs
Copy link
Member Author

szuecs commented Nov 28, 2023

👍

@szuecs szuecs merged commit 19f60cb into master Nov 28, 2023
8 checks passed
@szuecs szuecs deleted the cw2023freeze branch November 28, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants