docs: clarify clusterClientRatelimit empty client id logic #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
| and can be changed with an optional fourth parameter. | ||
| The optional fourth parameter may specify comma-separated list of header names. | ||
| Skipper will join header values to obtain client identity. | ||
| If identity value is empty (i.e. when all header values are empty or missing) then ratelimit does not apply. |
There was a problem hiding this comment.
minor: maybe be describe what if some values are empty or missing, but it seems optional for user documentation.
There was a problem hiding this comment.
All values must be missing/empty for the combined value to become empty (see TupleLookuper)
|
👍 |
|
BTW What does "#0" mean? |
|
👍 |
AlexanderYastrebov
deleted the
docs/reference/filters-clarify-clusterClientRatelimit-empty-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#0