go.mod: replace the old GH urls with renamed ones. #2782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sepehrdad Sh <26747519+sepehrdaddev@users.noreply.github.com>
|
👍 |
sepehrdaddev
added
security
dependencies
|
|
||
| replace github.com/armon/go-metrics v0.0.0-20180917152333-f0300d1749da => github.com/hashicorp/go-metrics v0.0.0-20180917152333-f0300d1749da | ||
|
|
||
| replace github.com/docker/docker v24.0.7+incompatible => github.com/moby/moby v24.0.7+incompatible |
There was a problem hiding this comment.
This (and some others) is indirect dependency and I believe it should be replaced in the package that brings it in.
Comment on lines
+194
to
+196
| replace github.com/uber/jaeger-lib v2.4.1+incompatible => github.com/jaegertracing/jaeger-lib v2.4.1+incompatible | ||
|
|
||
| replace github.com/uber/jaeger-client-go v2.30.0+incompatible => github.com/jaegertracing/jaeger-client-go v2.30.0+incompatible |
There was a problem hiding this comment.
These I would just remove #2153
There was a problem hiding this comment.
Not sure if we can just remove it for everyone @AlexanderYastrebov
|
👎 |
|
Replace directive breaks user code |
|
alright, thx for the review, I will close it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the old GH urls that have been renamed with their new ones