Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clusterfuzzlite PR fuzzing. #2784

Merged
merged 1 commit into from
Dec 8, 2023
Merged

add clusterfuzzlite PR fuzzing. #2784

merged 1 commit into from
Dec 8, 2023

Conversation

sepehrdaddev
Copy link
Member

@sepehrdaddev sepehrdaddev commented Dec 8, 2023

add clusterfuzzlite PR fuzzing.

it uses the same code as oss-fuzz but it will trigger fuzzing on every PR and it runs for 300 seconds

@sepehrdaddev sepehrdaddev added security github_actions Pull requests that update GitHub Actions code labels Dec 8, 2023
@AlexanderYastrebov
Copy link
Member

Won't this add 10 minutes to PR build?

@sepehrdaddev
Copy link
Member Author

it adds about 15 mins, yes, but the check is not mandatory for now.

@sepehrdaddev
Copy link
Member Author

the idea is to find bugs during PRs and not wait until the PR is merged and the targets are ran by oss-fuzz.

@szuecs
Copy link
Member

szuecs commented Dec 8, 2023

@sepehrdaddev that's too long maybe 2m?
It blocks the build

@sepehrdaddev
Copy link
Member Author

sepehrdaddev commented Dec 8, 2023

@szuecs I'm not sure which build you are referring to, the one that builds the docker images and etc run in parallel to this (in fact all the checks are running in parallel since this is a separate workflow)

as for the timing, it take about 5 mins to build the fuzzers, so I cannot change that but the remaining 10 mins I can change.

@sepehrdaddev
Copy link
Member Author

I have updated the fuzz-seconds to be 300 seconds so its a bit faster.

Signed-off-by: Sepehrdad Sh <26747519+sepehrdaddev@users.noreply.github.com>
@szuecs
Copy link
Member

szuecs commented Dec 8, 2023

👍

1 similar comment
@sepehrdaddev
Copy link
Member Author

👍

@szuecs szuecs merged commit 39eb3ef into master Dec 8, 2023
13 checks passed
@szuecs szuecs deleted the add-clusterfuzzlite branch December 8, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants