Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Al/fix gpu index #1270

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Al/fix gpu index #1270

merged 1 commit into from
Jun 27, 2024

Conversation

agnesLeroy
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@agnesLeroy agnesLeroy requested a review from pdroalves June 21, 2024 08:03
@cla-bot cla-bot bot added the cla-signed label Jun 21, 2024
Copy link
Contributor

@pdroalves pdroalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally a easy one to review :-D

This one is only changing variable names (stream => streams) and asserting we use the first active gpu index instead of 0, right? If so, we are god to go.

@zama-bot zama-bot removed the approved label Jun 27, 2024
@agnesLeroy agnesLeroy merged commit 3a2bb44 into main Jun 27, 2024
16 checks passed
@agnesLeroy agnesLeroy deleted the al/fix_gpu_index branch June 27, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants