Chore/add slsa framework #1281
Merged
Chore/add slsa framework #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aquint-zama
force-pushed
the
chore/add-slsa-framework
branch
6 times, most recently
from
4748ec8 to
2ebd51d
Compare
# Conflicts: # .github/workflows/make_release.yml
aquint-zama
force-pushed
the
chore/add-slsa-framework
branch
from
2ebd51d to
ae6020f
Compare
IceTDrinker
reviewed
Jul 16, 2024
aquint-zama
force-pushed
the
chore/add-slsa-framework
branch
from
ae6020f to
513bdba
Compare
IceTDrinker
reviewed
Jul 16, 2024
IceTDrinker
reviewed
Jul 16, 2024
IceTDrinker
reviewed
Jul 16, 2024
.github/workflows/make_release.yml
Outdated
| run: cd target/package && echo "hash=$(sha256sum ./*.crate | base64 -w0)" >> "${GITHUB_OUTPUT}" | ||
|
|
||
| provenance: | ||
| if: ${{ inputs.dry_run == "" }} |
There was a problem hiding this comment.
I think this should be
${{ !inputs.dry_run }}
as it's a boolean IIRC
aquint-zama
force-pushed
the
chore/add-slsa-framework
branch
from
513bdba to
96054b0
Compare
IceTDrinker
reviewed
Jul 17, 2024
IceTDrinker
reviewed
Jul 17, 2024
|
see https://github.com/zama-ai/tfhe-rs/actions/runs/9973464759/job/27558842192?pr=1281 I think you miss a steps. for the second part of the expression |
|
you can run make lint_workflow in the repo to check the workflows |
aquint-zama
force-pushed
the
chore/add-slsa-framework
branch
from
96054b0 to
4425160
Compare
aquint-zama
force-pushed
the
chore/add-slsa-framework
branch
from
4425160 to
6a4f053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: please link all relevant issues
PR content/description
Check-list: