Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): allow gpu workflows to run fast deduplicated default benchmarks #1357

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Jul 12, 2024

No description provided.

@soonum soonum added the ci label Jul 12, 2024
@soonum soonum requested review from agnesLeroy and IceTDrinker July 12, 2024 12:36
@soonum soonum self-assigned this Jul 12, 2024
@cla-bot cla-bot bot added the cla-signed label Jul 12, 2024
Some operations share the same underlying implementations (e.g.
max/min, left_shift/right_shift). Benchmarking these operations
can be considered as duplicate for developpers looking for fast
feedback on their changes.
Scalar operations are not included in this subset.
@soonum soonum force-pushed the dt/bench/dedup_ops branch from 2120a6b to ccb41e0 Compare July 12, 2024 12:39
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small remark and a question about whether FAST_BENCH is still used in the bench code

@soonum soonum force-pushed the dt/bench/dedup_ops branch from ccb41e0 to 813c99b Compare July 12, 2024 12:53
@soonum soonum requested a review from IceTDrinker July 12, 2024 12:53
@soonum soonum merged commit d824194 into main Jul 12, 2024
56 of 58 checks passed
@soonum soonum deleted the dt/bench/dedup_ops branch July 12, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants