fix(gpu): add missing delete #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbarbakadze
approved these changes
Jul 16, 2024
IceTDrinker
reviewed
Jul 16, 2024
Comment on lines
1035
to
+1038
| uint32_t gpu_count) { | ||
|
|
||
| lut->release(streams, gpu_indexes, 1); | ||
| delete lut; |
There was a problem hiding this comment.
question, I saw this pop up in the updates, gpu_count is ignored and 1 is hardcoded instead ?
There was a problem hiding this comment.
This is for the full propagation where the LUT is applied to only one input, so I hardcoded the value to 1 here yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: please link all relevant issues
PR content/description
Check-list: