Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bench): measure key sizes and zk proof sizes #1379

Merged
merged 3 commits into from
Jul 19, 2024
Merged

chore(bench): measure key sizes and zk proof sizes #1379

merged 3 commits into from
Jul 19, 2024

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Jul 17, 2024

No description provided.

@soonum soonum requested a review from IceTDrinker July 17, 2024 14:56
@soonum soonum self-assigned this Jul 17, 2024
@cla-bot cla-bot bot added the cla-signed label Jul 17, 2024
@IceTDrinker
Copy link
Member

I will take care of these edits

@IceTDrinker IceTDrinker force-pushed the am/chore/bench-size branch 2 times, most recently from 87d9df0 to 7293a5c Compare July 18, 2024 09:20
@IceTDrinker IceTDrinker requested a review from nsarlin-zama July 18, 2024 09:21
nsarlin-zama
nsarlin-zama reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@nsarlin-zama nsarlin-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One bench computes the size of the in-memory rust object while the other computes the size of the bincode serialized data. This could be uniformized later or at least specified in the function names.

tfhe/examples/utilities/shortint_key_sizes.rs Outdated Show resolved Hide resolved
soonum and others added 3 commits July 19, 2024 11:28
@soonum @IceTDrinker
chore(shortint): add constructor for compressed key switching key
8df918f
@soonum @IceTDrinker
chore(examples): measure more shortint key sizes
86e28ce
@IceTDrinker @soonum
chore(bench): measure proof size for zk benchmarks
d9f7349 
Also clean key sizes measurements since they are now done in
shortint_key_sizes.rs

Co-authored-by: David Testé <david.teste@zama.ai>
@IceTDrinker IceTDrinker force-pushed the am/chore/bench-size branch from 7293a5c to d9f7349 Compare July 19, 2024 09:29
@IceTDrinker IceTDrinker requested a review from nsarlin-zama July 19, 2024 09:29
nsarlin-zama
nsarlin-zama approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@nsarlin-zama nsarlin-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix !

@IceTDrinker IceTDrinker merged commit b700416 into main Jul 19, 2024
67 checks passed
@IceTDrinker IceTDrinker deleted the am/chore/bench-size branch July 19, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceTDrinker IceTDrinker IceTDrinker left review comments

@nsarlin-zama nsarlin-zama nsarlin-zama approved these changes

Assignees

@soonum soonum

Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soonum @IceTDrinker @nsarlin-zama @zama-bot