Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hl): wrong Named impl for CompressedCiphertextList #1384

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix(hl): wrong Named impl for CompressedCiphertextList #1384

merged 1 commit into from
Jul 18, 2024

Conversation

nsarlin-zama
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Jul 18, 2024
@nsarlin-zama nsarlin-zama requested a review from IceTDrinker July 18, 2024 09:58
IceTDrinker
IceTDrinker reviewed Jul 18, 2024
View reviewed changes
tfhe/src/high_level_api/compressed_ciphertext_list.rs
const NAME: &'static str = "high_level_api::CompactCiphertextList";
const NAME: &'static str = "high_level_api::CompressedCiphertextList";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be backported in 0.7 when you get some time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in the release PR

IceTDrinker
IceTDrinker approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@nsarlin-zama nsarlin-zama mentioned this pull request Jul 18, 2024
Merged
4 tasks
@nsarlin-zama nsarlin-zama merged commit f41d133 into main Jul 18, 2024
94 of 96 checks passed
@nsarlin-zama nsarlin-zama deleted the ns/fix_compressed_list_named branch July 18, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceTDrinker IceTDrinker IceTDrinker approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nsarlin-zama @IceTDrinker @zama-bot