-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ns/test data lists #1389
Ns/test data lists #1389
Conversation
needs a rebase and something is not passing in the build |
938d3f5
to
9694400
Compare
9694400
to
5d1607d
Compare
fast tests are skipped, better get the data workflow in a standalone file |
1e8a984
to
d6c737a
Compare
you need a tfhe-rs checkout to have the repo present |
d6c737a
to
71c1953
Compare
there must be a bug in my code to fetch labels, if need there should be a way to fetch labels of a PR with a github action |
or maybe something like in the approve_label workflow
change approved for the label you are interested in |
9048436
to
f6541a6
Compare
The workflows should work now:
These workflows consider that a branch in the data repo exists with the same name as the one with the |
For the moment the |
f6fe656
to
661ee6a
Compare
.github/workflows/data_pr_close.yml
Outdated
- name: Delete the associated branch in the data repo | ||
env: | ||
PR_BRANCH: ${{ github.head_ref || github.ref_name }} | ||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can have auto delete enabled in the data repo if needed later on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice, few comments on the new workflow which can likely be deduplicated to an extent
661ee6a
to
e46a373
Compare
PR content/description
Adds tests for heterogeneous lists: Compact (packed or not) and compressed.
This is linked to the following data PR: zama-ai/tfhe-backward-compat-data#14
Check-list: