Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mz/bench integer compression #1410

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Mz/bench integer compression #1410

merged 2 commits into from
Jul 25, 2024

Conversation

mayeul-zama
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jul 24, 2024
@mayeul-zama mayeul-zama requested a review from IceTDrinker July 24, 2024 08:32
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things otherwise thanks for the quick work on this

tfhe/benches/integer/glwe_packing_compression.rs Outdated Show resolved Hide resolved
tfhe/benches/integer/glwe_packing_compression.rs Outdated Show resolved Hide resolved
@mayeul-zama mayeul-zama force-pushed the mz/bench_integer_compression branch from 0ad3031 to 34cfe4c Compare July 24, 2024 12:22
let (compression_key, decompression_key) =
cks.new_compression_decompression_keys(&private_compression_key);

for num_bits in [8, 16, 32, 64, 128, 256] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doest his also cover the max capacity of the GLWE ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, lwe_per_glwe is 256

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except this is a number of bits so we would have 128 bodies, we should have a separate case that builds a number of bits for the max capcity

like

256, lwe_per_glwe * message_modulus.0.ilog2()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mayeul-zama mayeul-zama force-pushed the mz/bench_integer_compression branch from 34cfe4c to b7fbd7b Compare July 24, 2024 15:21
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot !

@mayeul-zama mayeul-zama merged commit c117798 into main Jul 25, 2024
64 of 67 checks passed
@mayeul-zama mayeul-zama deleted the mz/bench_integer_compression branch July 25, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants