chore(ci): include snippets folder into tfhe npm package (backport 0.7.x) #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
reviewed
Sep 26, 2024
| @@ -414,6 +414,7 @@ build_web_js_api_parallel: install_rs_check_toolchain install_wasm_pack | |||
| wasm-pack build --release --target=web \ | |||
| -- --features=boolean-client-js-wasm-api,shortint-client-js-wasm-api,integer-client-js-wasm-api,parallel-wasm-api,zk-pok \ | |||
| -Z build-std=panic_abort,std | |||
| jq '.files += ["snippets"]' tfhe/pkg/package.json > tmp_pkg.json && mv -f tmp_pkg.json tfhe/pkg/package.json | |||
There was a problem hiding this comment.
alignment isi not good, I think it breaks Makefiles
There was a problem hiding this comment.
It's ok, since it's not on the same line of command than the previous one.
IceTDrinker
reviewed
Sep 26, 2024
| image_id = "ami-051942e4055555752" | ||
| image_id = "ami-09b5f2f71828035d4" |
IceTDrinker
approved these changes
Sep 26, 2024
|
wasm tests are green, looking good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.